[17.0][FIX] purchase_manual_delivery: always call the full confirmation stack #2573
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppose you have module
purchase_x
that depends on purchase, and that it does an override ofbutton_confirm
to callfx
.Because
purchase_x
andpurchase_manual_delivery
have no relation to each other, we could either havepurchase_manual_delivery => purchase_x => purchase
, orpurchase_x => purchase_manual_delivery => purchase
.If you call button confirm, in all cases you will call
fx
once. If you call button_confirm_manual, in one case you will callfx
but not the other, depending on how the ORM loaded modules. If you decide that you want an easy solution and add an override of button_confirm_manual to also callfx
, then you have the possibility to callfx
twice, so you'd better be sure to make it idempotent.