Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][FIX] purchase_manual_delivery: always call the full confirmation stack #2573

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

len-foss
Copy link

Suppose you have module purchase_x that depends on purchase, and that it does an override of button_confirm to call fx.
Because purchase_x and purchase_manual_delivery have no relation to each other, we could either have purchase_manual_delivery => purchase_x => purchase, or purchase_x => purchase_manual_delivery => purchase.

If you call button confirm, in all cases you will call fx once. If you call button_confirm_manual, in one case you will call fx but not the other, depending on how the ORM loaded modules. If you decide that you want an easy solution and add an override of button_confirm_manual to also call fx, then you have the possibility to call fx twice, so you'd better be sure to make it idempotent.

@StefanRijnhart StefanRijnhart changed the title [FIX] purchase_manual_delivery: always call the full confirmation stack [17.0][FIX] purchase_manual_delivery: always call the full confirmation stack Feb 19, 2025
@StefanRijnhart StefanRijnhart added this to the 17.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants