[18.0][MIG] purchase_stock_secondary_unit: Migration to version 18.0 #2811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss the secondary unit from a purchase order to the related pickings
…r a purchase order is confirmed
Must be AGPL, as it depends on AGPL.
1. Automatic module migration to 14.0 by odoo-module-migrator 2. migrate failing unit test: Replace action_done by button_validate 3. black, isort, prettier (pre-commit) 4. setup added 5. added german translation
…ndary_qty from procurement
Currently translated at 100.0% (2 of 2 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_stock_secondary_unit Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_stock_secondary_unit/es/
… uom on stock moves linked to po lines
… as qty_done in sml's
eduezerouali-tecnativa
force-pushed
the
18.0-mig-purchase_stock_secondary_unit
branch
from
649edcc to
37b8b93
Compare
carlosdauden
suggested changes
Sep 15, 2025
| self.assertEqual(picking.move_lines.secondary_uom_qty, 0.0) | ||
| self.assertFalse(picking.move_lines.secondary_uom_id) | ||
| self.assertEqual(picking.move_lines.product_uom_qty, 10.0) | ||
| self.assertEqual(picking.move_line_ids.secondary_uom_qty, 0.0) |
There was a problem hiding this comment.
Why are you changing model operations (stock.move) by model detailed operations (stock.move.line)
The same applies to several of the changes in this file.
There was a problem hiding this comment.
You are right no need, should be move_ids.
eduezerouali-tecnativa
force-pushed
the
18.0-mig-purchase_stock_secondary_unit
branch
from
37b8b93 to
15e660e
Compare
carlosdauden
suggested changes
Sep 15, 2025
| picking = self.purchase_order.picking_ids | ||
| picking.action_assign() | ||
| picking.move_line_ids.qty_done = picking.move_lines.product_uom_qty | ||
| picking.move_ids.quantity = picking.move_ids.product_uom_qty |
There was a problem hiding this comment.
Is needed change picking.move_line_ids?
Test was changed due to now odoo auto set quantity if available.
eduezerouali-tecnativa
force-pushed
the
18.0-mig-purchase_stock_secondary_unit
branch
from
15e660e to
b907393
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT57652
ping @carlosdauden @sergio-teruel