[19.0][MIG] purchase_default_terms_conditions #2899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-12.0/purchase-workflow-12.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-12-0/purchase-workflow-12-0-purchase_default_terms_conditions/
Currently translated at 80.0% (8 of 10 strings) Translation: purchase-workflow-15.0/purchase-workflow-15.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-15-0/purchase-workflow-15-0-purchase_default_terms_conditions/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/
…hase_note on onchange of partner_id: this for manage case of purchase_note field on model partner that was deleted from backend but still evaluate <p><br></p> on db
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/it/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/es/
Currently translated at 100.0% (10 of 10 strings) Translation: purchase-workflow-16.0/purchase-workflow-16.0-purchase_default_terms_conditions Translate-URL: https://translation.odoo-community.org/projects/purchase-workflow-16-0/purchase-workflow-16-0-purchase_default_terms_conditions/pt_BR/
bosd
force-pushed
the
19.0-mig-purchase_default_terms_conditions
branch
from
36476ad to
464a0b7
Compare
bosd
force-pushed
the
19.0-mig-purchase_default_terms_conditions
branch
3 times, most recently
from
4f76244 to
c4c6051
Compare
1 It's generally better to call super() at the beginning of an overridden onchange method to ensure base logic is executed first. 2 The logic for setting the note is incomplete. If a partner is changed from one with a purchase_note to one without, and the company-level setting use_purchase_note is disabled, the note from the previous partner is kept. It should be cleared or reset. 3 The condition elif use_purchase_note and str2bool(use_purchase_note): can be simplified.
…d when partner has no note
bosd
force-pushed
the
19.0-mig-purchase_default_terms_conditions
branch
from
c4c6051 to
73a0d8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard migration using odoo-module-migrator
/ocabot migration purchase_default_terms_conditions .