[FIX] purchase_discount. Correct stock move price update on PO qty reduction (Multi-currency) #2903
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When reducing the quantity of a line in a confirmed Purchase Order (e.g., from 20 to 12 units), inconsistent behavior is observed depending on the currency of the provider:
Root Cause: The issue is located in the write() method override within purchase_discount. When a PO line is modified, the module updates the price_unit of the related stock moves using _get_discounted_price_unit().
Solution: This PR changes the method used to update the stock moves from _get_discounted_price_unit() to _get_stock_move_price_unit().
_get_stock_move_price_unit() is the standard method (inherited from purchase_stock) which: