Skip to content

[15.0][MIG] base_import_async #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

[15.0][MIG] base_import_async #430

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cf80f64
[FIX] Changes required to run on v_15
May 11, 2022
a1097be
[FIX] A checkbox for async import in a standard import wizard.
Apr 21, 2022
cd9a02c
[FIX] Standard import execution.
Apr 21, 2022
09deff8
[FIX] rename def do to execute_import
May 5, 2022
eaf99bf
[ADD] Make it installable
May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions base_import_async/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,15 @@
"website": "https://github.com/OCA/queue",
"category": "Generic Modules",
"depends": ["base_import", "queue_job"],
"data": ["data/queue_job_function_data.xml", "views/base_import_async.xml"],
"qweb": ["static/src/xml/import.xml"],
"data": ["data/queue_job_function_data.xml"],
"assets": {
"web.assets_backend": [
"base_import_async/static/src/js/import.js",
],
'web.assets_qweb': [
'base_import_async/static/src/xml/import.xml',
],
},
"installable": False,
Copy link
Member

@guewen guewen May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @RosSinch :)
It is still not installable 🤔

Copy link
Author

@RosSinch RosSinch May 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given up :)
I did it.
But could you please explain to me why it should be installable in v15 if it wasn't in v14?

Copy link
Member

@guewen guewen May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"installable": False, was false in v14 because nobody did the migration work in this version, so it could not be used in v14. Perhaps odoo will still install it using the -i option, not sure, but this would be a kind of bug, the module would be shown as uninstallable in the UI.

As I understand you actually did the migration work so the module runs on v15, then the module should be flagged as installable, it would be a pity if the module cannot be installed if you made it installable, right? :)

Copy link
Author

@RosSinch RosSinch May 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are absolutely right. It should be installable and it can, because the work is done for this.

Copy link
Author

@RosSinch RosSinch May 18, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen
@simahawk
Is PR ready to merge?

Copy link
Contributor

@simahawk simahawk May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is 🔴
Also, please, when you get back to it, squash your commits and rewrite the 1 remaining as [15.0][MIG] base_import_async

"development_status": "Production/Stable",
}
4 changes: 2 additions & 2 deletions base_import_async/models/base_import_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
class BaseImportImport(models.TransientModel):
_inherit = "base_import.import"

def do(self, fields, columns, options, dryrun=False):
def execute_import(self, fields, columns, options, dryrun=False):
if dryrun or not options.get(OPT_USE_QUEUE):
# normal import
return super().do(fields, columns, options, dryrun=dryrun)
return super().execute_import(fields, columns, options, dryrun=dryrun)

# asynchronous import
try:
Expand Down
2 changes: 1 addition & 1 deletion base_import_async/static/src/xml/import.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8" ?>
<templates>
<t t-extend="ImportView">
<t t-extend="ImportView.side_panel">
<t t-jquery="#oe_import_has_header" t-operation="before">
<div
title="When checked, the import will be executed as a background job,
Expand Down