Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] base_report_to_printer: 1030: The printer or class does not exist #258

Closed
wants to merge 1 commit into from

Conversation

hugho-ad
Copy link

Before this commit a error 1030: The printer or class does not exist because cups tried to print using uri printer
now configuring cups.setServer and cups.setPort as recommended at
http://nagyak.eastron.hu/doc/system-config-printer-libs-1.2.4/pycups-1.9.51/html/cups.Connection-class.html

it's working well

Before this commit a error 1030: The printer or class does not exist because cups tried to print using uri printer
now configuring cups.setServer and cups.setPort as recommended at
http://nagyak.eastron.hu/doc/system-config-printer-libs-1.2.4/pycups-1.9.51/html/cups.Connection-class.html

it's working well
@hugho-ad
Copy link
Author

@moylop260 @JulioSerna could you review pls?

@moylop260
Copy link

It could have compatibility errors if an old version of pycups is installed

What about using pycups>=1.9.51 from:

@moylop260
Copy link

Could you check it, please?

@max3903 @gdgellatly
@CarlosRoca13 @igh-fp @schout-it

@gdgellatly
Copy link
Contributor

Hi @hugho-ad ,

This PR makes no sense to me in the context of the linked documentation.

A connection to the CUPS server. Before it is created the connection server and username should be set using cups.setServer and cups.setUser; otherwise the defaults will be used

So far so good. Now the very next line

The constructor takes optional arguments host, port, and encryption, which default to the values of cups.getServer(), cups.getPort(),

In this PR, you set the server and port, and then subsequently overwrite it in the very next argument where you construct the connection class. But they are set identically as before. So whatever is working or not, it cannot seem related to this or the linked documentation is wrong.

For me I need more specifics on why the existing code doesn't work and why this PR fixes it, as honestly, right now it just looks like 2 useless lines.

@rousseldenis
Copy link
Contributor

Done in #262

This is a duplicate

@hugho-ad hugho-ad closed this Dec 9, 2021
@moylop260
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants