[ADD] sale_order_type: change of analytical account by project

[matiasperalta1]

No description provided.

[nicolascol]

LGTM

[nicolascol]

Hi @rvalyi !
Can you merge this PR?
We added the "project_id" because of the new analytic approach in v18.
Odoo PR with new approach

[rousseldenis]

@matiasperalta1 Could you rename your commit and this description as this is more correct: [IMP] sale_order_type: Use project instead of analytic account on types.

But, with this change, existing installs will loose data. It should contain migration scripts if possible.

[rousseldenis]

But, IMHO, this is not correct as analytic account still exists.

This is a change of behavior as an analytic account is not a project. That's why you've added a new dependency from sale_project.

If you want to assign a project to the type, you should do a new module that allow that.

[nicolascol]

Hi @rousseldenis
The "analytic_account_id" field doesn't exist in sale.order v18, Odoo replaced it with "project_id". More info
This PR was made to adapt sale_order_type to v18. In sale_order_type v17 an "analytic_account_id" could be configured. In the v18 migration PR we were evaluating this change to adapt it but that PR was merged and that is why we are now making this new PR.

[StefanRijnhart]

Can you add a migration script to assign the project with the account_id matching the original analytic_account_id values on the order types?

[rousseldenis]

@matiasperalta1 Could you fix tests ?

[jjscarafia]

@rousseldenis @StefanRijnhart @matiasperalta1
As I understand:

1. the analytic_account_id is not used anymore, could be removed

2. if we want to add some new functionality related to "analytics" maybe we should add :
   2a. add an "analytic_distribution" field (I believe this would be cleaner)
   2b. or extends analytic distribution models to be able to map with types

3. If there is need to set "project_id" by a sale order type (not linked to analytics need), I agree that a new module would be needed

What do you think of going with "1" and "2a"?