[18.0] sale_restricted_qty: Migration to 18.0 #3609

samirGuesmi · 2025-03-03T11:13:44Z

No description provided.

… and manual_force_sale_max_qty (imp user UI)

… other module & pep8

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/

Currently translated at 100.0% (51 of 51 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/it/

rousseldenis · 2025-03-31T14:45:49Z

/ocabot migration sale_restricted_qty

rousseldenis · 2025-03-31T14:52:01Z

sale_restricted_qty/tests/test_sale.py

+                {"partner_id": self.partner.id, "order_line": [(0, 0, line_values)]}
+            )
+            sale_values = self.refrech_sale_values(sale_order)
+            self.sale_order_model.create(sale_values)


@samirGuesmi Could you check why tests are not reaching this line? I think I don't see any refrech_sale_values method.

@rousseldenis I deleted these lines, they were most propably forgotten during a previous update.

bosd · 2025-10-13T21:41:04Z

Can you please recreate a runboat?

marielejeune

LGTM (code review)

bosd

Thanks for your work on this, but the Functional test made me very confused:

Set a min quantity on a product of 100.
Add 50 pieces of the product to an so.
Confirm the SO.
Result
There was no warning, that my quantity is below minimum. SO got confirmed.
Expected result
A warning that I am selling below the MOQ. Unable to confirm the SO.

Then I Tried to copy that Saleorder.
Now there is an error message that my MOQ is below the minimum 😕 ❔
The message:

If you want sell quantity less than Min Quantity,Check "force min quatity" on product

quantity

So if I understand this correctly, I have to enable the enforce min quantity to be able to use less then the minimum quantity? 🧠 ❓

bosd · 2025-10-20T22:33:00Z

sale_restricted_qty/models/sale.py

+            ) + "\n ".join(invaild_min_lines)
+            msg += _(
+                "\n* If you want sell quantity less than Min Quantity"
+                ',Check "force min quatity" on product'


Suggested change

',Check "force min quatity" on product'

',Check "force min quantity" on product'

bosd · 2025-10-20T22:33:24Z

sale_restricted_qty/models/sale.py

+            ) + "\n ".join(invaild_max_lines)
+            msg += _(
+                "\n* If you want sell quantity bigger than max Quantity"
+                ',Check "force max quatity" on product'


Suggested change

',Check "force max quatity" on product'

',Check "force max quantity" on product'

bosd · 2025-10-20T22:33:47Z

sale_restricted_qty/readme/DESCRIPTION.md

@@ -0,0 +1,10 @@
+This module allows to define min, max and multiple order quantity on
+product. Min and Max order quantity is either required or recommanded.


Suggested change

product. Min and Max order quantity is either required or recommanded.

product. Min and Max order quantity is either required or recommended.

bosd · 2025-10-20T22:52:44Z

Seems like most of my comments are actually already been addressed in: #2997 by @alexey-pelykh
Is that still a WIP or ready to be included here?

alexey-pelykh · 2025-10-21T05:49:24Z

@bosd already used in production, I wanted to merge migration first and then refactored one - but it's ready

alexey-pelykh · 2025-10-21T06:53:34Z

Idea is that #2997 completely remade the UI as current one less than optimal let's say, so migration to 18.0 should've included that. However as #2996 has been in review for one year 7 months (completely normal phenomenon for a functioning organization), obviously this migration does not include it

mourad-ehm and others added 22 commits March 3, 2025 11:34

[IMP] rename module sale_order_min_qty to sale_restricted_qty

0c98d65

[FIX] Update Readme & "use_parent" value to manual_force_sale_min_qty…

a5f1ec1

… and manual_force_sale_max_qty (imp user UI)

[IMP] views & fix is_qty_less_min_qty & is_qty_bigger_max_qty

b8f5adc

[IMP] add _get_sale_restricted_qty on sale to make qty overridable by…

2c6e43a

… other module & pep8

[FIX] _compute_sale_restricted_qty

61233d3

[FIX] restricted_qty UserError Message

e9310f2

[FIX] openupgradelib requirements.txt

ed77bf5

[REF] refactor code to make it simplier and inheritable

443b17f

[FIX] _compute_is_qty_less bigger multiple qty

1a7e350

Added translation using Weblate (Italian)

c82c5d7

[14.0][MIG] sale_restricted_qty: Migration to 14.0

aef858e

Translated using Weblate (Italian)

ae82cae

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

[IMP] sale_restricted_qty: show sale_min sale_max optionally

3cd82de

[IMP] sale_restricted_qty: Change dp.get_precision digits

9e34074

Translated using Weblate (Italian)

ce8eca4

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

Added translation using Weblate (French)

82772a1

Translated using Weblate (Italian)

b4279b2

Currently translated at 100.0% (54 of 54 strings) Translation: sale-workflow-14.0/sale-workflow-14.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_restricted_qty/it/

[MIG] sale_restricted_qty: Migration to 16.0

64ebcc0

[UPD] Update sale_restricted_qty.pot

7420d57

Translated using Weblate (Italian)

66607a5

Currently translated at 100.0% (51 of 51 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_restricted_qty Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_restricted_qty/it/

[IMP] sale_restricted_qty: pre-commit auto fixes

a922b1b

samirGuesmi force-pushed the 18.0-mig-sale_restricted_qty branch from ae9714d to ad4ba87 Compare March 3, 2025 11:34

rousseldenis added needs review migration labels Mar 31, 2025

OCA-git-bot added this to the 18.0 milestone Mar 31, 2025

OCA-git-bot mentioned this pull request Mar 31, 2025

Migration to version 18.0 #3344

Open

rousseldenis reviewed Mar 31, 2025

View reviewed changes

[MIG] sale_restricted_qty: Migration to 18.0

6f52440

samirGuesmi force-pushed the 18.0-mig-sale_restricted_qty branch from ad4ba87 to 6f52440 Compare April 2, 2025 13:34

etobella force-pushed the 18.0 branch from 4e676b6 to a6df617 Compare October 8, 2025 08:27

marielejeune approved these changes Oct 15, 2025

View reviewed changes

bosd suggested changes Oct 20, 2025

View reviewed changes

	',Check "force min quatity" on product'
	',Check "force min quantity" on product'

	',Check "force max quatity" on product'
	',Check "force max quantity" on product'

		@@ -0,0 +1,10 @@
		This module allows to define min, max and multiple order quantity on
		product. Min and Max order quantity is either required or recommanded.

Uh oh!

[18.0] sale_restricted_qty: Migration to 18.0 #3609

Are you sure you want to change the base?

[18.0] sale_restricted_qty: Migration to 18.0 #3609

Uh oh!

Conversation

samirGuesmi commented Mar 3, 2025

Uh oh!

rousseldenis commented Mar 31, 2025

Uh oh!

rousseldenis Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

samirGuesmi Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

bosd commented Oct 13, 2025

Uh oh!

marielejeune left a comment

Choose a reason for hiding this comment

Uh oh!

bosd left a comment

Choose a reason for hiding this comment

Uh oh!

bosd Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

bosd Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

bosd Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

bosd commented Oct 20, 2025

Uh oh!

alexey-pelykh commented Oct 21, 2025

Uh oh!

alexey-pelykh commented Oct 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants