[MIG] sale_order_line_remove: Migration to 18.0

[JochenDeBie]

No description provided.

[rousseldenis]

/ocabot migration sale_order_line_remove

[BhaveshHeliconia]

Funtional test LG.

[matteonext]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[ivs-cetmix]

Hi @JochenDeBie , please squash administrative commits (if any) with the previous commit for reducing commit noise. Check the migration wiki for details, ensue that you have followed all the steps of that document.
Please prefix your pr with the version tag as well: [18.0][MIG]....

[ivs-cetmix]

Thank you!

[ivs-cetmix]

Hi @JochenDeBie, commits are good now, please fix the tests.

[JochenDeBie]

@ivs-cetmix Not really sure what to do with this one. The test that is failing now was added in another module to specifically check that confirmed SO lines can't be removed, which is the purpose of this module:

https://github.com/OCA/sale-workflow/blame/43f33c42b51eff3b3e3b88f571aec541ce72530f/sale_order_product_recommendation/tests/test_recommendation.py#L207

[ivs-cetmix]

@ivs-cetmix Not really sure what to do with this one. The test that is failing now was added in another module to specifically check that confirmed SO lines can't be removed, which is the purpose of this module:

https://github.com/OCA/sale-workflow/blame/43f33c42b51eff3b3e3b88f571aec541ce72530f/sale_order_product_recommendation/tests/test_recommendation.py#L207

Looks like we need to use rebel modules here. I'm not very familiar with this flow, so probably we need to ask @dreispt or @pedrobaeza how to do this right.

[ArnauCForgeFlow]

Hello, what's the state of this PR? @ivs-cetmix @JochenDeBie I can help if needed.

[ivs-cetmix]

Code review LGTM

[ivs-cetmix]

Hello, what's the state of this PR? @ivs-cetmix @JochenDeBie I can help if needed.

Hi @ArnauCForgeFlow , thank you! Could you please check how we can solve an issue with those tests falling?

[ArnauCForgeFlow]

@ivs-cetmix @JochenDeBie I think rebel modules are needed here. I don’t have much experience with rebel modules, but I think you need to update the copier answers and include this module as a rebel module.

[ivs-cetmix]

That's the

@ivs-cetmix @JochenDeBie I think rebel modules are needed here. I don’t have much experience with rebel modules, but I think you need to update the copier answers and include this module as a rebel module.

Unfortunately I don't have much experience with them either. Would appreciate if @rousseldenis @sbidoul or @dreispt could give a helper hand here.