Skip to content

Conversation

@bizzappdev
Copy link
Contributor

No description provided.

@bizzappdev bizzappdev marked this pull request as ready for review May 6, 2025 07:53
@rousseldenis
Copy link
Contributor

/ocabot migration sale_auto_remove_zero_quantity_lines

"removed upon confirmation."
)
order.message_post(body=body)
zero_or_empty_lines.unlink()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bizzappdev Could you improve this in order to gather lines in loop and unlink at the end ? Thanks

@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_auto_remove_zero_quantity_lines-BAD branch from 29045a0 to cfb36c4 Compare July 21, 2025 12:58
@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_auto_remove_zero_quantity_lines-BAD branch from cfb36c4 to 78b9a17 Compare September 1, 2025 12:29
or (line.display_type == "line_note" and not line.name.strip())
)
if zero_or_empty_lines:
body = _(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
body = _(
body = self.env._(

@bizzappdev bizzappdev force-pushed the 18.0-mig-sale_auto_remove_zero_quantity_lines-BAD branch from 78b9a17 to 1f4d3a8 Compare September 8, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants