[18.0] [MIG] sale_invoice_plan: Migration to 18.0

[bizzappdev]

No description provided.

[rousseldenis]

@bizzappdev Still draft ?

[bizzappdev]

@rousseldenis Yes, some manual test cases failed, we are working on the Fixes. next week it might be ready.

[bizzappdev]

@rousseldenis MR is ready for the review.

[rousseldenis]

/ocabot migration sale_invoice_plan

[Pani-k-folk]

Suggested change

	_("Please fill percentage for all invoice plan lines")
	self.env._("Please fill percentage for all invoice plan lines")

Please replace all _ with self.env._ to improve performance in some cases.

According to the migration list to 18.0 at https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0

[Pani-k-folk]

remark : Renaming the view ID from 'tree' to 'list' is optional.

[Pani-k-folk]

Suggested change

	<record model="ir.ui.view" id="view_sale_invoice_plan_tree">
	<record model="ir.ui.view" id="view_sale_invoice_plan_list">

[Pani-k-folk]

Suggested change

	<field name="name">view.sale.invoice.plan.tree</field>
	<field name="name">view.sale.invoice.plan.list</field>

[Pani-k-folk]

Suggested change

	context="{'tree_view_ref': 'sale_invoice_plan.view_sale_invoice_plan_tree'}"
	context="{'list_view_ref': 'sale_invoice_plan.view_sale_invoice_plan_list'}"

[Pani-k-folk]

Suggested change

	<field name="name">view.sale.invoice.plan.tree</field>
	<field name="name">view.sale.invoice.plan.list</field>

[Pani-k-folk]

Suggested change

	<record id="view_sale_invoice_plan_tree_readonly" model="ir.ui.view">
	<record id="view_sale_invoice_plan_list_readonly" model="ir.ui.view">

[Pani-k-folk]

Suggested change

	<field name="view_mode">tree</field>
	<field name="view_mode">list</field>

[Pani-k-folk]

Could you please change the tree view mode to list, as the tree view is no longer in use and it's currently preventing the Sale Invoice Plan window from opening

[Pani-k-folk]

Suggested change

	<field name="view_id" ref="view_sale_invoice_plan_tree_readonly" />
	<field name="view_id" ref="view_sale_invoice_plan_list_readonly" />

[bizzappdev]

@Pani-k-folk Changes are done.

[Pani-k-folk]

@bizzappdev
Why are you show distribution_analytic_account_ids (analytic_account_id) in the Invoice Plan? Shouldn't it be analytic_distribution instead? Also, is this part still necessary to show?"

[rousseldenis]

Mmmhh, I'm not sure of that. Naming a field with an id' and Ḿany2many` is not correct.

This should be changed.

[niboo-ave]

Odoo.sh raise an error while doing test:
`
2025-06-23 08:37:34,264 4 ERROR ****-feature--9-21418645 odoo.addons.base.tests.test_views: Please indicate why the always invisible fields are present in the view, or remove the field tag.

Addon: 'sale_invoice_plan'

View: view_order_form_invoice_plan

Fields:

    <field name="invoice_plan_process" invisible="1"/>

View: view_sale_invoice_plan_list
Fields:

     <field name="no_edit" column_invisible="1"/>
     <field name="last" column_invisible="1"/>

`
I assume it's due to the 1 that should be rename to "True" ?

Other than that, i did some functional testing and seems to be great.

[rousseldenis]

LGTM

[Saran440]

@bizzappdev Hi, Did you still do this PR?
I test and found 2 bug (may be other version is bug too)

1. Error when change QTY = 0.0 after create invoice plan 1 line:
   Step to error:
   1. Create Quotation with invoice plan
   2. Confirm > Create Invoice by Plan > Create Next Invoice
   3. It still worked, until you change quantity in quotation to 0.0 > Save
   
   
   4. It will show error, and you can't click to this document
   

I solved by check condition amount_untaxed

@api.depends("percent")
    def _compute_amount(self):
        for rec in self:
            amount_untaxed = rec.sale_id._origin.amount_untaxed
            if not amount_untaxed:
                continue

---

2. amount_invoiced field support only 1 invoice. For my case, we can created invoice > 1 (split by vat and no vat) but amount_invoiced compute by first invoiced only. Is it possible to change method to support more than 1 invoice?

path: sale_invoice_plan/models/sale_invoice_plan.py

    def _get_amount_invoice(self, invoices):
        """Get amoutn invoice from same order"""
        amount_invoiced = sum(invoices.mapped("amount_untaxed"))
        lines = invoices.mapped("invoice_line_ids").filtered(
            lambda ml: ml.product_id.id and self.sale_id in ml.sale_line_ids.mapped("order_id")
        )
        amount_invoiced = sum(lines.mapped("price_subtotal"))
        return amount_invoiced

    @api.depends("invoice_move_ids.state")
    def _compute_invoiced(self):
        for rec in self:
            invoiced = rec.invoice_move_ids.filtered(
                lambda move_line: move_line.state in ("draft", "posted")
            )
            rec.invoiced = True if invoiced else False
            rec.amount_invoiced = (
                sum(invoiced.mapped("amount_untaxed"))
                if rec.invoice_type == "advance"
                else rec._get_amount_invoice(invoiced)
            )

[TheerayutEncoder]

Hi @bizzappdev, is it possible to mark a draft as ready for review?

[bizzappdev]

@Saran440 Changes are done.
@TheerayutEncoder It is now ready for review.

[Saran440]

Code Review 👍

[Saran440]

Just a little comment.
no need to add because odoo will auto use string Invoice Plan

[Saran440]

@bizzappdev Thanks for your work.
@Pani-k-folk @TheerayutEncoder Please check this PR.

If it's okay, let's we merge.