[ADD] sale_order_compute_commitment_date: New module sale_order_compute_commitment_date #3775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_commitment_date
mpascuall
force-pushed
the
18.0-add-sale_order_compute_commitment_date
branch
from
ad03179 to
01c9036
Compare
| class ProductTemplate(models.Model): | ||
| _inherit = "product.template" | ||
|
|
||
| extend_lead_time = fields.Boolean( |
Contributor
There was a problem hiding this comment.
IMHO, this field name should reflect the attribute term as the name is too generic.
Something like attribute_extend_lead_time.
| ) | ||
|
|
||
| @api.depends( | ||
| "order_line.product_id", |
Contributor
There was a problem hiding this comment.
IMHO, only order_line.product_id should be taken into account here.
You should manage the fact changing the delay, the product variant lead time or the extend configuration will trigger a compute on every existing sale order line that uses that product. And that is unwanted behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module automatically computes sale orders commitment date based on the product template sale_delay
and product attribute variant lead time fields.
cc https://github.com/APSL 14210
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @BernatObrador @ppyczko please review