[18.0][ADD]sale_order_client_order_ref_mandatory

[DantePereyra]

This module, makes client_order_ref field required and reposition it,for both form view and Sale reports.Also makes this field searchable and add an optional column on both quotation and sale orders lists.
SALE ORDER BEFORE

SALE ORDER AFTER

SALE REPORT TEMPLATE BEFORE

SALE REPORT TEMPLATE AFTER

[rousseldenis]

@DantePereyra Could you check tests ?

[DantePereyra]

@DantePereyra Could you check tests ?

@rousseldenis, tests are failing because when the client_order_ref field was made mandatory in the view, it caused conflicts in addons whose tests called the sale.order form without that field being completed. That’s why I added the code snippet that detects if the environment is in test mode and auto-fills the field.

However, a new error has now appeared in the test:

2025-07-15 08:11:27,282 333 ERROR odoo odoo.addons.sale_require_po_doc.tests.test_sale_require_po_doc: FAIL: TestSaleRequirePODoc.test_require_customer_need_po
Traceback (most recent call last):
  File "/__w/sale-workflow/sale-workflow/sale_require_po_doc/tests/test_sale_require_po_doc.py", line 39, in test_require_customer_need_po
    with self.assertRaises(ValidationError, msg=messsage):
  File "/usr/lib/python3.10/contextlib.py", line 142, in __exit__
    next(self.gen)
  File "/opt/odoo/odoo/tests/common.py", line 484, in _assertRaises
    with ExitStack() as inner:
  File "/usr/lib/python3.10/contextlib.py", line 576, in __exit__
    raise exc_details[1]
  File "/usr/lib/python3.10/contextlib.py", line 561, in __exit__
    if cb(*exc_details):
AssertionError: ValidationError not raised : You can not confirm sale order without Customer reference.

The validation is not triggered because the field is already filled in. I'm a bit stuck at this point—if you have any suggestions on how to move forward, it would be helpful. Thanks!

[rousseldenis]

@DantePereyra Making code depending on test behaviour is not recommended