[18.0][MIG]: sale_order_invoice_amount #3819

sbiosca-s73 · 2025-07-17T09:15:40Z

Standard migration to v18

rousseldenis · 2025-07-17T09:32:09Z

/ocabot migration sale_order_invoice_amount

Reyes4711-S73 · 2025-07-29T07:42:54Z

LGTM

BhaveshHeliconia

Functional review LGTM!

OCA-git-bot · 2025-08-26T12:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

sbiosca-s73 · 2025-08-28T10:58:44Z

@rousseldenis can you merge please?

rousseldenis · 2025-08-29T06:46:28Z

@sbiosca-s73 No need of migration script for fields renaming ?

DavidJForgeFlow · 2025-10-02T06:58:33Z

Hi @sbiosca-s73, there were some changes in v17.0 removing amount_invoiced and amount_to_invoice. Please could you get the recent changes to have both versions aligned?

17.0 PR: #3537

DavidJForgeFlow · 2025-10-20T10:15:59Z

Superseded in #3955 as it needs more changes.

rousseldenis · 2025-10-21T07:42:12Z

@sbiosca-s73 Do you agree we move to #3955 ?

sbiosca-s73 · 2025-10-21T09:16:26Z

@DavidJForgeFlow Sorry, I missed your suggestion.

@rousseldenis I have seen the new PR, and I agree those canges look like correct migration, but i have a doubt about _compute_amount_to_invoice and _compute_amount_invoiced. @DavidJForgeFlow according with your comment, you removed this computes because Odoo base already handles the functionality. David, I see URL change Odoo base in your PR, but i'm not clear on how it replaces the functionality from OCA module. Could you please explain me why the OCA logic is no longer necessary? Once we clarify this, we can decide whether to keep the changes in your PR or apply them to this.

Thanks!

DavidJForgeFlow · 2025-11-04T12:01:26Z

@DavidJForgeFlow Sorry, I missed your suggestion.

@rousseldenis I have seen the new PR, and I agree those canges look like correct migration, but i have a doubt about _compute_amount_to_invoice and _compute_amount_invoiced. @DavidJForgeFlow according with your comment, you removed this computes because Odoo base already handles the functionality. David, I see URL change Odoo base in your PR, but i'm not clear on how it replaces the functionality from OCA module. Could you please explain me why the OCA logic is no longer necessary? Once we clarify this, we can decide whether to keep the changes in your PR or apply them to this.

Thanks!

Hi @sbiosca-s73,
The computation of both fields was done in the migration to v17.0 (that's why we deleted the invocied_amount and uninvoiced_amount). However the amount_to_invoice was still being computed taking into account the amount left and ignoring the quantity of products invoiced. For example, if I sell 2 units at 15 €/unit, If I has an invoice of 1 unit with amount 20€, the amount_to_invoice was 10€. In this module the amount was 15€ as one unit was left to invoice.
This was changed in v18.0 in the commit I commented. Now the computation is the same and therefore we can remove the method (also taking into account the changes in currencies are also treated).

sbiosca-s73 · 2025-11-19T08:44:12Z

@DavidJForgeFlow @rousseldenis I have implemented the correct migration changes that David mentioned, so we can close PR #3955 and we can respect this PR as the initial migration. Thank you.

DavidJForgeFlow

Great! Thanks @sbiosca-s73, I will then close the other PR. COuld you please review this?

sale_order_invoice_amount/static/src/xml/tax_totals.xml

sale_order_invoice_amount/views/sale_order_view.xml

sbiosca-s73 · 2025-11-19T14:41:29Z

@DavidJForgeFlow done! Thank you

sale_order_invoice_amount/views/sale_order_view.xml

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_invoice_amount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_invoice_amount/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_invoice_amount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_invoice_amount/fr/

Currently translated at 100.0% (5 of 5 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_order_invoice_amount Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_order_invoice_amount/it/

…d not total amount

sbiosca-s73 · 2025-12-01T09:56:54Z

@DavidJForgeFlow done, thank you!

sbiosca-s73 force-pushed the 18.0-mig_sale_order_invoice_amount branch from db50d2f to 2ec400c Compare July 17, 2025 09:30

OCA-git-bot added this to the 18.0 milestone Jul 17, 2025

rousseldenis added needs review migration labels Jul 17, 2025

OCA-git-bot mentioned this pull request Jul 17, 2025

Migration to version 18.0 #3344

Open

sbiosca-s73 force-pushed the 18.0-mig_sale_order_invoice_amount branch from 2ec400c to 0813cd2 Compare July 24, 2025 06:49

Reyes4711-S73 approved these changes Jul 29, 2025

View reviewed changes

Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025

build(oca/18): OCA/sale-workflow#3819

cb0c6bf

BhaveshHeliconia approved these changes Aug 26, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Aug 26, 2025

etobella force-pushed the 18.0 branch from 4e676b6 to a6df617 Compare October 8, 2025 08:27

DavidJForgeFlow mentioned this pull request Oct 20, 2025

[18.0][MIG] sale_order_invoice_amount #3955

Closed

sbiosca-s73 force-pushed the 18.0-mig_sale_order_invoice_amount branch 2 times, most recently from b2a8091 to 1bc550c Compare November 19, 2025 07:58

DavidJForgeFlow reviewed Nov 19, 2025

View reviewed changes

sale_order_invoice_amount/static/src/xml/tax_totals.xml Outdated Show resolved Hide resolved

sale_order_invoice_amount/static/src/xml/tax_totals.xml Outdated Show resolved Hide resolved

sale_order_invoice_amount/views/sale_order_view.xml Outdated Show resolved Hide resolved

sbiosca-s73 force-pushed the 18.0-mig_sale_order_invoice_amount branch from 1bc550c to 2b46113 Compare November 19, 2025 14:29

DavidJForgeFlow approved these changes Nov 19, 2025

View reviewed changes

DavidJForgeFlow suggested changes Nov 27, 2025

View reviewed changes

sale_order_invoice_amount/views/sale_order_view.xml Outdated Show resolved Hide resolved

OCA-git-bot removed approved ready to merge labels Nov 27, 2025

MateuGForgeFlow and others added 21 commits December 1, 2025 10:54

[ADD] sale_order_invoice_amount

36301cb

[IMP] sale_order_invoice_amount: black, isort, prettier

6ee0c9e

[MIG] sale_order_invoice_amount: Migration to 14.0

218588b

[MIG] sale_order_invoice_amount: Migration to 15.0

b880613

[MIG] sale_order_invoicing_finished_task: Migration to 15.0

712939a

[MIG] sale_order_invoice_amount: Migration to 16.0

c0fe3b2

[UPD] README.rst

15c5dd3

[UPD] README.rst

262da22

Added translation using Weblate (French)

c845441

Added translation using Weblate (Italian)

46d3524

[IMP] sale_order_invoice_amount: make sure to respect currencies

26be062

[IMP] sale_order_invoice_amount: uninvoiced amount checks qty invoice…

2b07e41

…d not total amount

[BOT] post-merge updates

78b0a9d

[IMP] sale_order_invoice_amount: pre-commit stuff

272858c

[MIG] sale_order_invoice_amount: Migration to 17.0

35a26e0

[IMP] sale_order_invoice_amount: Invoice calculation based on quantities

ec25a9b

[IMP] sale_order_invoice_amount: pre-commit auto fixes

fffffff

[MIG] sale_order_invoice_amount: Migration to 18.0

d877f5d

sbiosca-s73 force-pushed the 18.0-mig_sale_order_invoice_amount branch from 2b46113 to d877f5d Compare December 1, 2025 09:56

Uh oh!

[18.0][MIG]: sale_order_invoice_amount #3819

Are you sure you want to change the base?

[18.0][MIG]: sale_order_invoice_amount #3819

Uh oh!

Conversation

sbiosca-s73 commented Jul 17, 2025

Uh oh!

rousseldenis commented Jul 17, 2025

Uh oh!

Reyes4711-S73 commented Jul 29, 2025

Uh oh!

BhaveshHeliconia left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Aug 26, 2025

Uh oh!

sbiosca-s73 commented Aug 28, 2025

Uh oh!

rousseldenis commented Aug 29, 2025

Uh oh!

DavidJForgeFlow commented Oct 2, 2025

Uh oh!

DavidJForgeFlow commented Oct 20, 2025

Uh oh!

rousseldenis commented Oct 21, 2025

Uh oh!

sbiosca-s73 commented Oct 21, 2025

Uh oh!

DavidJForgeFlow commented Nov 4, 2025

Uh oh!

sbiosca-s73 commented Nov 19, 2025

Uh oh!

DavidJForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sbiosca-s73 commented Nov 19, 2025

Uh oh!

Uh oh!

sbiosca-s73 commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants