-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[14.0][IMP] sale_exception: SO line inherit change to base.exception #3861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 14.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx. One minor remark.
Could you please add the open PR as temporary reference as it is described here. https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29
PR 3354 in OCA/server-tools removed in base_exception the reverse fields. They are here not used in another context, so they can be removed
4717614 to
449b976
Compare
|
@rousseldenis, can you check this here? This relates to the other PRs I created for repo server-tools. The 2nd commit with the most changes could be separated by the PRs I mentioned in the commit message. But I didn't do it because the differences would only be in the unit tests to check for the blocking text |
|
On a database with a lot of sale order lines the computation of |
…emented new def in sale.order PR 3365 in OCA/server-tools introduced a more general way to handle sub-exceptions on the lines PR 3346 adjusted the blocking text in the exceptions summary
449b976 to
837d60c
Compare
Hi.
Because of my other PR OCA/server-tools#3346 I changed
sale_exceptionto use more ofbase_exception. Some fields are added again tosale.order.lineeventhough they already exist onbase.exception.With these changes the note "(Is blocking)" now also appears in the exceptions summary on the SO line. Previously not as
sale.order.linedefined its own computation for this field.And with the new inherit it has now the field
main_exception_id.Here I did more changes than in other modules that depend on
base_exceptionto remove the duplicated stuff