Skip to content

Conversation

@raumschmiede-joshuaL
Copy link

Hi.

Because of my other PR OCA/server-tools#3346 I changed sale_exception to use more of base_exception. Some fields are added again to sale.order.line eventhough they already exist on base.exception.

With these changes the note "(Is blocking)" now also appears in the exceptions summary on the SO line. Previously not as sale.order.line defined its own computation for this field.
And with the new inherit it has now the field main_exception_id.

Here I did more changes than in other modules that depend on base_exception to remove the duplicated stuff

@raumschmiede-joshuaL
Copy link
Author

Copy link

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. One minor remark.
Could you please add the open PR as temporary reference as it is described here. https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

PR 3354 in OCA/server-tools removed in base_exception the reverse fields. They are here not used in another context, so they can be removed
@raumschmiede-joshuaL
Copy link
Author

@rousseldenis, can you check this here? This relates to the other PRs I created for repo server-tools.

The 2nd commit with the most changes could be separated by the PRs I mentioned in the commit message. But I didn't do it because the differences would only be in the unit tests to check for the blocking text

@raumschmiede-joshuaL
Copy link
Author

raumschmiede-joshuaL commented Sep 23, 2025

On a database with a lot of sale order lines the computation of main_exception_id will take a long time. I will add a migration script to add this field directly to the table without computation. The exceptions are already on exception_ids, and the field is not displayed. No need to set it in the script

…emented new def in sale.order

PR 3365 in OCA/server-tools introduced a more general way to handle sub-exceptions on the lines
PR 3346 adjusted the blocking text in the exceptions summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants