[18.0][FIX] sale_order_secondary_unit: quantity resets to 0 with secondary UoM #3873
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi @pedrobaeza, can you check this PR? |
pedrobaeza
changed the title
Member
|
@sergio-teruel is more suitable than me for checking this. |
Contributor
Author
|
Hi @sergio-teruel could you check this? |
bosd
approved these changes
Sep 13, 2025
mav-adhoc
reviewed
Sep 17, 2025
| if self.secondary_uom_id: | ||
| if line_uom_qty == 1.0: | ||
| self.secondary_uom_qty = 1.0 | ||
| self._onchange_helper_product_uom_for_secondary() |
There was a problem hiding this comment.
instead of _onchange_helper_product_uom_for_secondary(), you should call the _compute_helper_target_field_qty() method, otherwise when the product qty is 1 and makes the comparison (in the if) to insert 1 unit in the secondary unit, after introducing 1 unit in the secondary qty, it introduces again 1 unit in the product original qty and makes the convertion.
lef-adhoc
force-pushed
the
18.0-t-98836-lef
branch
from
b738e3f to
78ef0a5
Compare
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the product_uom_qty on a sale order line would reset to 0 when adding a product that uses a secondary unit of measure.
The logic that prevented this in previous versions was altered during the migration to v17 (#3385)