Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 90 additions & 0 deletions sale_order_line_remove/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,90 @@
======================
Sale Order Line Remove
======================

..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:19987b79fe99d4ff465bda1d9b1f07c5570e70b5347127ddb2dcc5849efb6bc4
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsale--workflow-lightgray.png?logo=github
:target: https://github.com/OCA/sale-workflow/tree/18.0/sale_order_line_remove
:alt: OCA/sale-workflow
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/sale-workflow-18-0/sale-workflow-18-0-sale_order_line_remove
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/sale-workflow&target_branch=18.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module allows the removal of sale order lines even after the order
has been confirmed, under certain conditions. Specifically, a sale order
line can be removed if:

- It has not been invoiced.
- It has not been delivered.

**Table of contents**

.. contents::
:local:

Usage
=====

Once the module is installed:

1. Go to a sale order.
2. You can now delete a sale order line if it hasn't been invoiced or
delivered.

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/sale-workflow/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/sale-workflow/issues/new?body=module:%20sale_order_line_remove%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
-------

* ForgeFlow

Contributors
------------

- Joan Sisquella <[email protected]>

Maintainers
-----------

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/sale-workflow <https://github.com/OCA/sale-workflow/tree/18.0/sale_order_line_remove>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 1 addition & 0 deletions sale_order_line_remove/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
16 changes: 16 additions & 0 deletions sale_order_line_remove/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com)
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).
{
"name": "Sale Order Line Remove",
"version": "18.0.1.0.0",
"category": "Sales",
"summary": "Allows removal of sale order lines from confirmed "
"orders if not invoiced or received",
"author": "ForgeFlow, Odoo Community Association (OCA)",
"website": "https://github.com/OCA/sale-workflow",
"license": "AGPL-3",
"depends": ["sale_stock", "sale_management"],
"data": ["views/res_config_settings_views.xml"],
"installable": True,
"application": False,
}
31 changes: 31 additions & 0 deletions sale_order_line_remove/i18n/sale_order_line_remove.pot
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Translation of Odoo Server.
# This file contains the translation of the following modules:
# * sale_order_line_remove
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 15.0\n"
"Report-Msgid-Bugs-To: \n"
"Last-Translator: \n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: \n"
"Plural-Forms: \n"

#. module: sale_order_line_remove
#: model:ir.model,name:sale_order_line_remove.model_sale_order_line
msgid "Sales Order Line"
msgstr ""

#. module: sale_order_line_remove
#: code:addons/sale_order_line_remove/models/sale_order.py:0
#, python-format
msgid "You can not remove an order line that has been delivered"
msgstr ""

#. module: sale_order_line_remove
#: code:addons/sale_order_line_remove/models/sale_order.py:0
#, python-format
msgid "You can not remove an order line that has been invoiced"
msgstr ""
2 changes: 2 additions & 0 deletions sale_order_line_remove/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import sale_order
from . import res_config_settings
14 changes: 14 additions & 0 deletions sale_order_line_remove/models/res_config_settings.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Copyright 2025 ForgeFlow, S.L. (https://www.forgeflow.com)
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

from odoo import fields, models


class ResConfigSettings(models.TransientModel):
_inherit = "res.config.settings"
restrict_sale_order_line_remove = fields.Boolean(
"Allow Sale Order Line Remove",
config_parameter="sale.order.line.remove",
help="Allow removing confirmed sale order lines only "
"if they are not invoiced or delivered.",
)
60 changes: 60 additions & 0 deletions sale_order_line_remove/models/sale_order.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
# Copyright 2023 ForgeFlow, S.L. (https://www.forgeflow.com)
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

from odoo import _, models
from odoo.exceptions import UserError


class SaleOrderLine(models.Model):
_inherit = "sale.order.line"

def _check_line_unlink(self):
non_removable_lines = super()._check_line_unlink()
if (
not self.env["ir.config_parameter"]
.sudo()
.get_param("sale.order.line.remove")
):
return non_removable_lines
else:
removable_lines = self.filtered(
lambda line: line.state in ("sale", "done")
and not line.invoice_lines
and not line.move_ids.filtered(lambda move: move.state == "done")
)
invoiced_lines = self.sudo().filtered(
lambda line: line.state in ("sale", "done") and line.invoice_lines
)
if invoiced_lines:
raise UserError(
_("You can not remove an order line that has been invoiced")
)
delivered_lines = self.sudo().filtered(
lambda line: line.state in ("sale", "done")
and line.move_ids.filtered(lambda move: move.state == "done")
)
if delivered_lines:
raise UserError(
_("You can not remove an order line that has been delivered")
)
return non_removable_lines - removable_lines

def unlink(self):
non_removable_lines = self._check_line_unlink()
if (
not self.env["ir.config_parameter"]
.sudo()
.get_param("sale.order.line.remove")
):
return super().unlink()
else:
for line in self - non_removable_lines:
related_pickings = line.move_ids.mapped("picking_id")
line.move_ids.filtered(
lambda move: move.state not in ("done", "cancel")
)._action_cancel()
line.move_ids.filtered(lambda move: move.state != "done").unlink()
for picking in related_pickings:
if not picking.move_ids_without_package:
picking.unlink()
return super().unlink()
3 changes: 3 additions & 0 deletions sale_order_line_remove/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"
1 change: 1 addition & 0 deletions sale_order_line_remove/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Joan Sisquella \<[email protected]\>
6 changes: 6 additions & 0 deletions sale_order_line_remove/readme/DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
This module allows the removal of sale order lines even after the order
has been confirmed, under certain conditions. Specifically, a sale order
line can be removed if:

- It has not been invoiced.
- It has not been delivered.
5 changes: 5 additions & 0 deletions sale_order_line_remove/readme/USAGE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Once the module is installed:

1. Go to a sale order.
2. You can now delete a sale order line if it hasn't been invoiced or
delivered.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading