[19.0][MIG] sale_delivery_split_date: Migration to 19.0 #3948
Conversation
* [ADD] sale_delivery_split_date module * [ADD] sale_delivery_split_date: add computed min_dt to allow deliveries to be searchable by the scheduled date
Note that sale_delivery_split_date is not compatible with sale_procurement_group_by_commitment_date
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-14.0/sale-workflow-14.0-sale_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_delivery_split_date/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-16.0/sale-workflow-16.0-sale_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_delivery_split_date/
Currently translated at 100.0% (2 of 2 strings) Translation: sale-workflow-16.0/sale-workflow-16.0-sale_delivery_split_date Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-16-0/sale-workflow-16-0-sale_delivery_split_date/it/
|
/ocabot migration sale_delivery_split_date |
| <head> | ||
| <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> | ||
| <meta name="generator" content="Docutils: https://docutils.sourceforge.io/" /> | ||
| <title>Sale Delivery Split Date</title> |
There was a problem hiding this comment.
Is this change generated by pre-commit? Strange change to <title>README.rst</title>
There was a problem hiding this comment.
Yes, it is precommit doing the change...
yankinmax
left a comment
yankinmax
left a comment
There was a problem hiding this comment.
pre-approve considering a question
Tatider
force-pushed
the
19.0-mig-sale-delivery-split-date
branch
from
dfe8fef to
9bebdaf
Compare
|
One of the dependencies to be renamed, waiting for the final name to be defined - "#3947" |
Tatider
force-pushed
the
19.0-mig-sale-delivery-split-date
branch
from
9bebdaf to
99c6967
Compare
Updated |
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
small comment, non blocking
| if self.commitment_date: | ||
| comm_date = self._get_security_lead_time_commitment_date() | ||
| vals["name"] += "/" + format_date(self.env, comm_date.date()) | ||
| vals["name"] = ( |
There was a problem hiding this comment.
Maybe it's just me, but I found it was more readable before.
Why this change? it doesn't seem like an useful diff
There was a problem hiding this comment.
To my understanding, usage of "+=" for strings is considered a bad practice, bacause it might lead to unxpected errors when one of arguments is not a string, f.e. "False" as it might be with Sale Line Name
15 participants
Depends on: