Skip to content

[18.0][FIX] sale_exception: handle exception rollback in action_confirm method #3952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lef-adhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+5 −0
Draft

[18.0][FIX] sale_exception: handle exception rollback in action_confirm method #3952

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sale_exception/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ def sale_check_exception(self):

def action_confirm(self):
if self.detect_exceptions():
exception_map = {sale.id: sale.exception_ids.ids for sale in self}
self.env.cr.rollback()
for sale in self:
exception_ids = exception_map.get(sale.id, [])
sale.write({"exception_ids": [(6, 0, exception_ids)]})
if not self.env.company.sale_exception_show_popup:
return
return self._popup_exceptions()
Expand Down
Loading