[19.0][IMP] sale_order_type: Remove redundant company domain from journal_id #4000
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explicit company domain in journal_id field is redundant because the check_company=True attribute already handles company filtering correctly. The check_company mechanism automatically filters records based on the appropriate companies, including parent companies when working with child companies (branches). This provides the correct Odoo behavior for multi-company scenarios. This simplification makes the code cleaner and aligns with standard Odoo patterns for company-dependent fields.
Contributor
Author
|
@pedrobaeza What do you think about this PR? |
pedrobaeza
approved these changes
Nov 10, 2025
nicolascol
approved these changes
Nov 11, 2025
nicolascol
left a comment
nicolascol
left a comment
There was a problem hiding this comment.
LGTM functional review
@pedrobaeza Could you merge please?
Contributor
|
This PR has the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit company domain in journal_id field is redundant because the check_company=True attribute already handles company filtering correctly.
The check_company mechanism automatically filters records based on the appropriate companies, including parent companies when working with child companies (branches). This provides the correct Odoo behavior for multi-company scenarios.
This simplification makes the code cleaner and aligns with standard Odoo patterns for company-dependent fields.