[19.0][REF] sale_order_type: Remove unused analytic_account_id field #4001
+0
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analytic_account_id field was defined in the sale.order.type model but was not being used anywhere in the module's logic. This field has no practical functionality in the current implementation. Additionally, this field was removed from the standard Odoo sale.order model in version 18.0
lef-adhoc
changed the title
Contributor
Author
|
@pedrobaeza Could you check this? |
Member
|
Well, I think the goal is to have a default analytic mapping, but as you say, right now it hasn't been covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analytic_account_id field was defined in the sale.order.type model but was not being used anywhere in the module's logic. This field has no practical functionality in the current implementation.
Additionally, this field was removed from the standard Odoo sale.order model in version 18.0