[MIG] sale_substate: Migration to 19.0 #4056
Conversation
Co-authored-by: Kitti U. @ Ecosoft <[email protected]>
OCA Review : Typo & oca dependency Co-authored-by: Daniel Reis <[email protected]>
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-17.0/sale-workflow-17.0-sale_substate Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-17-0/sale-workflow-17-0-sale_substate/
|
This module (sale_substate) has been successfully migrated from Odoo v18 to v19. Thanks in advance! |
|
@np-oerp In order to review functionaly with runboat and in order to get green tests, you can follow this : https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29 |
|
/ocabot migration sale_substate |
np-oerp
force-pushed
the
19.0-mig-sale_substate
branch
9 times, most recently
from
fdf366e to
a78fa5b
Compare
|
I've added the necessary test-requirements.txt (referencing the base_substate PR) to the repository root. This resolve the Runboat test. Could you please check and confirm if this is correct? Thank you. |
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
I think this should solve some of your red tests.
|
Also your last two commits can be squashed. |
np-oerp
force-pushed
the
19.0-mig-sale_substate
branch
from
cd0c41f to
0fe2c30
Compare
|
Hi @rrebollo Thank you for the feedback. I’ve applied the suggested changes and squashed the commits accordingly. |
|
Hi @rrebollo Just following up on this PR. The code review has been completed—could you please let me know if any next steps are needed from my side, or if it can be merged? Thank you. |
|
@np-oerp you need at least another approval or someone with merging capabilities to get this done. One way to get reviewers is to review other's PRs, maybe on this same repository, and request them to return the favor. |
12 participants
This module is depends on base_substate module. For that, The reference PR ([19.0][MIG] base_substate server-ux#1198).
CC: @flotho @absal-smile @eugen-don @gaelTorrecillas