[18.0][ADD] sale_order_line_base_price_and_has_discount #4064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rousseldenis given the picture in PR description, is the design/inspiration for this feature influenced by or related to the EE? |
rrebollo
approved these changes
Dec 13, 2025
Comment on lines
15
to
30
| @api.depends("product_id", "order_id.pricelist_id", "base_price") | ||
| def _compute_has_discount_price(self): | ||
| lines_with_product = self.filtered("product_id") | ||
| for line in lines_with_product: | ||
| pricelist_price = line._get_pricelist_price() | ||
| base_price = line.base_price | ||
| line.has_discount_price = bool(pricelist_price < base_price) | ||
| (self - lines_with_product).has_discount_price = False | ||
|
|
||
| @api.depends("product_id") | ||
| def _compute_base_price(self): | ||
| lines_with_product = self.filtered("product_id") | ||
| for line in lines_with_product: | ||
| base_price = line._get_pricelist_price_before_discount() | ||
| line.base_price = base_price | ||
| (self - lines_with_product).base_price = False |
There was a problem hiding this comment.
Did you consider compute both fields in a single method? I'm not sure it would be a good idea due to the differences in the re computation triggers but ... I'm just asking
… base price computation method In some cases, we want to display the base price from pricelists based on formulas and not only on discount cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.