[19.0][IMP] sale_require_po_doc-default: Set default 'Customer Requires PO' at company level #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rousseldenis
approved these changes
Dec 12, 2025
rrebollo
reviewed
Dec 13, 2025
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
The implementation looks solid from a technical perspective. Code structure, logic, and style are well-executed.
Consideration for improvement: Would you be open to adding a basic test case to validate the new approach?
|
If you happen to implement the test ping me. I will give you my approve. Also, would you be so kind to review my work (#4072) back? |
AaronHForgeFlow
force-pushed
the
19.0-imp-sale_require_po_doc-default
branch
from
1976c7c to
9e3266e
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some companies this requirement is for all customers, so this setting allow you to do that without changing current behavior