[18.0][MIG] sale_warn_option: Migration to 18 #4074
Conversation
sabrinaRMartin
force-pushed
the
18.0-mig-sale_warn_option
branch
from
29aae8e to
5cdc7b5
Compare
sabrinaRMartin
changed the title
sabrinaRMartin
force-pushed
the
18.0-mig-sale_warn_option
branch
4 times, most recently
from
186daac to
529f8ac
Compare
Shide
left a comment
Shide
left a comment
There was a problem hiding this comment.
Code and functional review. Good job!
sabrinaRMartin
force-pushed
the
18.0-mig-sale_warn_option
branch
2 times, most recently
from
b376240 to
4efdb72
Compare
loida-vm
left a comment
loida-vm
left a comment
There was a problem hiding this comment.
Thank you @sabrinaRMartin for your work:
The following scenarios have been tested:
-
Warning (customer and product)
-
Blocking Message (customer and product)
All 4 tests passed successfully, and I’m attaching an image as evidence
The warning message appears, but it allows you to continue. It’s just a notice
_The warning message appears, but it allos you to continue._
_The notice appears and doesn’t allow adding the product to the SO._
_The notice appears and doesn’t allow adding the customer to the SO._
Additionally, regarding the comment left in purchase_warn_option
I have verified the behavior and it is correct. I prepared a short video showing that the system allows specifying whether a message is a warning or a blocking message. The warning option can apply to both types, and only when a specific option is selected is the corresponding message added.
sale_warn_option.mp4
Thank you for everything!
LGTM! PR approved!
sabrinaRMartin
force-pushed
the
18.0-mig-sale_warn_option
branch
from
b20660d to
2219b28
Compare
sabrinaRMartin
force-pushed
the
18.0-mig-sale_warn_option
branch
from
2219b28 to
5add563
Compare
|
Review OK after last commit |
|
/ocabot migration sale_warn_option |
rafaelbn
left a comment
rafaelbn
left a comment
There was a problem hiding this comment.
Funcional review
/ocabot merge patch
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-4074-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
…k and warning message
Shide
force-pushed
the
18.0-mig-sale_warn_option
branch
from
5add563 to
8d744dc
Compare
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c514fc9. Thanks a lot for contributing to OCA. ❤️ |
5 participants
Migration from 15.0 to 18.0
This module depends on PR:
@moduon @Shide MT-13048
https://www.loom.com/share/9cb07dcac5fa421cb9fbe85c5fd2604b