Skip to content

[16.0][FIX] sale_order_invoice_amount: Fix invoice amount calc when order a… #4075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aritzolea wants to merge 1 commit into
base: 16.0
Choose a base branch
from
+10 −10
Open

[16.0][FIX] sale_order_invoice_amount: Fix invoice amount calc when order a… #4075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sale_order_invoice_amount/models/sale_order.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def _compute_invoice_amount(self):
and rec.currency_id != invoice.company_currency_id
):
rec.invoiced_amount += invoice.currency_id._convert(
invoice.amount_total_signed,
invoice.amount_total_in_currency_signed,
rec.currency_id,
invoice.company_id,
invoice.invoice_date or fields.Date.today(),
Expand Down
18 changes: 9 additions & 9 deletions sale_order_invoice_amount/tests/test_sale_order_invoice_amount.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,10 @@ def test_02_sale_order_invoiced_amount_different_currencies_invoice(self):
}
)
test_invoice.action_post()
self.assertAlmostEqual(
self.assertEqual(
self.sale_order_1.invoiced_amount,
242.0,
delta=1,
242.11,
"Invoiced Amount should be 242.11.",
)
self.assertEqual(
self.sale_order_1.uninvoiced_amount,
Expand Down Expand Up @@ -311,10 +311,10 @@ def test_03_sale_order_invoiced_amount_different_currencies_sale(self):
}
)
test_invoice.action_post()
self.assertAlmostEqual(
self.assertEqual(
self.sale_order_1.invoiced_amount,
242.0,
delta=40,
242.13,
"Invoiced Amount should be 242.13.",
)
self.assertEqual(
self.sale_order_1.uninvoiced_amount,
Expand Down Expand Up @@ -387,10 +387,10 @@ def test_03_sale_order_invoiced_amount_different_currencies_sale(self):
]
)
test_invoice.action_post()
self.assertAlmostEqual(
self.assertEqual(
self.sale_order_1.invoiced_amount,
363.0,
delta=100,
363.06,
"Invoiced Amount should be 363.06.",
)
self.assertEqual(
self.sale_order_1.uninvoiced_amount,
Expand Down