[FIX] sale_invoice_blocking: return text in _nothing_to_invoice_error_message #4087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return error message directly instead of a UserError to prevent an error when this module is used together with the enterprise subscription module which tries to append its own message.
rousseldenis
changed the title
| error = super()._nothing_to_invoice_error_message() | ||
| error += _("\n- You may have an invoice blocking reason on the sale order") | ||
|
|
||
| return UserError(error) |
Contributor
There was a problem hiding this comment.
@damdam-s The fix seems legit as the error is raised later. Do you know why you did this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return error message directly instead of a UserError to prevent an error when this module is used together with the enterprise subscription module which tries to append its own message:
result = _call_kw_multi(method, model, args, kwargs)
File "/opt/odoo/src/odoo/odoo/api.py", line 469, in _call_kw_multi
result = method(recs, *args, **kwargs)
File "/opt/odoo/src/enterprise/sale_subscription/models/sale_order.py", line 731, in action_invoice_subscription
raise UserError(self._nothing_to_invoice_error_message())
File "/opt/odoo/src/enterprise/sale_subscription/models/sale_order.py", line 1534, in _nothing_to_invoice_error_message
error_message += _(
TypeError: unsupported operand type(s) for +=: 'UserError' and 'str'