[17.0][MIG] auth_jwt: Migration to 17.0 #657
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it allows validating with a list of audiences.
Make it work with pyjwt.
This method is useful for public endpoints that need to work for anonymous user, but can be enhanced when an authenticated user is know. A typical use case is a "add to cart" enpoint that can work for anonymous users, but can be enhanced by binding the cart to a known customer when the authenticated user is known.
The unit tests were broken for non-functional reasons (interaction with the mock) and is easier to implement as integration test.
Distinguish errors that lead to a 401 from internal configuration errors.
Extract _parse_bearer_authorization function for easier reuse by fastapi_auth_jwt
Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/es/
Currently translated at 89.0% (57 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
Currently translated at 100.0% (64 of 64 strings) Translation: server-auth-16.0/server-auth-16.0-auth_jwt Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-auth_jwt/it/
kwoychesko
pushed a commit
to bpmi/server-auth
that referenced
this pull request
Jun 5, 2024
* [MIG] migrate users_ldap_populate to 10.0 Changes include: - move views to views folder - move models to models folder - in views rename openerp to odoo - __openerp__.py to __manifest__.py * [FIX] Add read me to module users_ldap_populate * [FIX] users_ldap_populate: cleanup manifest file Cleanup of the author list * [FIX] users_ldap_populate: More modern copyright in .py files * [FIX] users_ldap_populate: Update read me Fixes include: - more human module name - Fix web links
sbidoul
reviewed
Jun 6, 2024
| self.assertEqual( | ||
| str(composite_error.exception), | ||
| "401 Unauthorized: " | ||
| + "Multiple errors occurred during JWT chain validation:\n" |
There was a problem hiding this comment.
Suggested change
| + "Multiple errors occurred during JWT chain validation:\n" | |
| "Multiple errors occurred during JWT chain validation:\n" |
Was this + added automatically by ruff ?
There was a problem hiding this comment.
Yikes, what's this pandoc-3.2.1-amd64.deb doing here?
There was a problem hiding this comment.
it already landed in the 17.0 branch! https://github.com/OCA/server-auth/tree/17.0 Here was the culprit #641
ryanc-me
pushed a commit
to ryanc-me/server-auth
that referenced
this pull request
Jul 30, 2024
* [MIG] migrate users_ldap_populate to 10.0 Changes include: - move views to views folder - move models to models folder - in views rename openerp to odoo - __openerp__.py to __manifest__.py * [FIX] Add read me to module users_ldap_populate * [FIX] users_ldap_populate: cleanup manifest file Cleanup of the author list * [FIX] users_ldap_populate: More modern copyright in .py files * [FIX] users_ldap_populate: Update read me Fixes include: - more human module name - Fix web links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the manifest to version 17.0.1.0.0.
Updated the XML file to be supported by Odoo version 17.0.