Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth_saml: feat: set timeout for lock on update provider #677

Open
wants to merge 1 commit into
base: 14.0
Choose a base branch
from
Open

auth_saml: feat: set timeout for lock on update provider #677

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions auth_saml/models/auth_saml_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,6 +421,8 @@ def action_refresh_metadata_from_url(self):

if not providers_to_update:
return False
# Set the local timeout to 15 sec to avoid deadlocks when all token expired
self.env.cr.execute("SET LOCAL lock_timeout = '15s'")
Comment on lines +424 to +425
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the local timeout to 15 sec to avoid deadlocks when all token expired
self.env.cr.execute("SET LOCAL lock_timeout = '15s'")
# Set the local timeout to 15 sec to avoid deadlocks when all token expired
self.env.cr.flush()
self.env.cr.execute("SET LOCAL lock_timeout = '15s'")


# lock the records we might update, so that multiple simultaneous login
# attempts will not cause concurrent updates
Expand Down
Loading