Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][FIX][IMP] base_user_role_profile : add the missing swiching widget, add new options to further improve the usability #310

Open
wants to merge 10 commits into
base: 14.0
Choose a base branch
from

Conversation

nayatec
Copy link

@nayatec nayatec commented Sep 27, 2024

As described in the USAGE.rst the base_user_role_profile module is supposed to allow a user to switch between 'role profiles' that are allowed to he or she, which are basically a way of adding or removing roles depending on the profile, therefore dynamically changing the user's rights.

Unfortunately the switching widget allowing the user to do so was removed from the module.

This PR put it back, with some fixes, and add new options to allow a bit more flexibility in it's use.
Some tests we added too.

@nayatec
Copy link
Author

nayatec commented Sep 27, 2024

cc @kevinkhao @Kev-Roche

Copy link
Contributor

@ypapouin ypapouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on a demo database.

Comment on lines 12 to 13
aria-label="Dropdown menu"
title="Dropdown menu"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-label="Switch profile"
title="Switch profile"

ypapouin pushed a commit to decgroupe/server-backend that referenced this pull request Oct 14, 2024
…he missing swiching widget, add new options to further improve the usability
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants