-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[ADD] access_limit_records_number: migrated to v18 #3394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
|
You are not respecting commit history nor doing the operation in a proper way, as there's a merge commit in your history. You should also check that the original authors signed the OCA CLA. |
2da6de7 to
55600bf
Compare
|
Hi Pedro, I deleted the last commit. There was just a conflict in the README.md. I believe there were other contributions to this repository while waiting for this pull request to be reviewed. |
|
@holasoftware As @pedrobaeza said, you need to follow this migration guide : https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0 |
|
Hi @rousseldenis, could you be specific if you see a problem with the migration? Then I can make the appropriate changes. |
Please follow migration guide. You should keep commits history |
|
@rousseldenis What do you mean to keep commit history? |
I migrated the module
access_limit_records_numberfrom herehttps://github.com/it-projects-llc/access-addons
to version 18.