Skip to content

[18.0][FIX] base_tier_validation: approve by pass sequence continue only #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[18.0][FIX] base_tier_validation: approve by pass sequence continue only #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions base_tier_validation/models/tier_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,9 +533,26 @@ def _validate_tier(self, tiers=False):
}
)

user_reviews = tier_reviews.filtered(
lambda r: r.status == "pending" and (self.env.user in r.reviewer_ids)
)
user_reviews = self.env[tier_reviews._name]
found_start = False

for review in tier_reviews:
is_match = review.status == "pending" and (
self.env.user in review.reviewer_ids
)
if is_match and not found_start:
found_start = True
user_reviews |= review
if not review.approve_sequence_bypass:
break
continue

if is_match and found_start:
user_reviews |= review

if not is_match and found_start:
break

user_reviews.write(
{
"status": "approved",
Expand Down
Loading