[16.0][FIX] announcement: Avoid user login error #1152
Merged
+106
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use case example: - Create an announcement and link users A + B - Modify the announcement and leave it linked only to user A - Try to log in with user B Previously, it was not possible to log in because user B still had the announcement linked (unread_announcement_ids) to their user, and when trying to log in, an attempt was made to access a record that the user could not access (except with Announcement Manager permission). TT58023
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 5e60b43. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid user login error
Use case example:
Previously, it was not possible to log in because user B still had the announcement linked (unread_announcement_ids) to their user, and when trying to log in, an attempt was made to access a record that the user could not access (except with Announcement Manager permission).
Please @david-banon-tecnativa and @CarlosRoca13 can you review it?
@Tecnativa TT58023