19.0 [MIG] base tier validation #1176
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu
…reviews' name and state correctly translated.
* using similar approach to activities has already benn addressed. * add a new point explaining review tooltip improvement possibilities.
Currently translated at 100.0% (59 of 59 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation/zh_CN/
notification to possible reviewers.
* fix test after the last forward-ported feature. * add a descrition of new know issue.
… rebranding of Eficent to ForgeFlow.
…tified. A customer or supplier can be a follower of the object and should not receive internal messages about the tier validation.
Currently translated at 100.0% (74 of 74 strings) Translation: server-ux-13.0/server-ux-13.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-13-0/server-ux-13-0-base_tier_validation/zh_CN/
…pute_domain_reviewer_field
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/nl/
Changes done: - The subtypes should not be defined as default=True to avoid that a follower receives notifications of everything (even if he/she doesn't really need it). - When adding followers they are added to the corresponding subtype so that the notification arrives to whom it corresponds. - Improve the code so that the reviews to notify are the "following ones according to the sequence". TT56354
config When an Odoo model inherits from `tier.validation` but sets up `_tier_validation_manual_config = True`, adding `review_ids` in a form view with the `tier_validation` widget causes Owl errors. It appears that the Tier Review fields are then not passed to the Owl framework, and accessing them in the widget template raises exceptions. Adding the fields used in the `base_tier_validation.Collapse` template to the component under the `relatedFields` key fixes this, while not changing the behavior for models using `_tier_validation_manual_config = False`.
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/it/
… that it can be used in searchs. Similar to kevinkhao@217de7c TT56391
Odoo in V18 raises an error if the signature of the function is not strictly (cr, version). See: https://github.com/odoo/odoo/blob/2a839ef1ed09c36f27ce7536ca3052d9f65ceed9/odoo/modules/migration.py#L252-L256
…rs in field-based validation
…w_ids in a one2many When the validations are in a model that is inside another model, after the reviews are approved, trying to open the one2many raises an error. This commit ensures that the value is taken from the correct record instead of env.model.root, which represents the main model and not the model that inherits tier.validation.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/
Currently translated at 100.0% (146 of 146 strings) Translation: server-ux-18.0/server-ux-18.0-base_tier_validation Translate-URL: https://translation.odoo-community.org/projects/server-ux-18-0/server-ux-18-0-base_tier_validation/it/
lmignon
requested changes
Oct 31, 2025
Contributor
lmignon
left a comment
lmignon
left a comment
There was a problem hiding this comment.
The code LGTM but AFAIK this addon should be moved into a dedicated repository https://github.com/OCA/tier-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
68 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.