Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] mail_activity_partner: Migration to version 16.0 #1156

Merged
merged 18 commits into from
Nov 17, 2023
Merged

[16.0][MIG] mail_activity_partner: Migration to version 16.0 #1156

merged 18 commits into from
Nov 17, 2023

Conversation

polqubiq
Copy link
Contributor

@polqubiq polqubiq commented Jun 6, 2023

No description provided.

AdriaGForgeFlow and others added 17 commits June 6, 2023 13:22
@AdriaGForgeFlow @polqubiq
[12.0][ADD] Add module mail_activity_partner
212306b 
[IMP] Change partner_id to a computed field

[IMP] Add tests to increase coverage
@OCA-git-bot @polqubiq
[UPD] README.rst
40bde70
@oca-travis @polqubiq
[UPD] Update mail_activity_partner.pot
eb54ea7
@OCA-git-bot @polqubiq
[ADD] icon.png
97f68b2
@OCA-git-bot @polqubiq
[UPD] README.rst
3503379
@AdriaGForgeFlow @polqubiq
[IMP] mail_activity_partner: black, isort
e52b2fe
@AdriaGForgeFlow @polqubiq
[MIG] mail_activity_partner: Migration to 13.0
0cad0a8
@oca-travis @polqubiq
[UPD] Update mail_activity_partner.pot
4f7e6a7
@polqubiq
[IMP] pre-commit run -a
13820e0
@Rad0van @polqubiq
[MIG] mail_activity_partner: Migration to 14.0
acd72ef
@oca-travis @polqubiq
[UPD] Update mail_activity_partner.pot
2c57d4a
@OCA-git-bot @polqubiq
[UPD] README.rst
18ecf20
@JoanMForgeFlow @polqubiq
[15.0][MIG] mail_activity_partner: Migration to 15.0
13a42a5
@polqubiq
[UPD] Update mail_activity_partner.pot
2a0c829
@OCA-git-bot @polqubiq
[UPD] README.rst
1c8dd5a
@victoralmau @polqubiq
[FIX] mail_activity_partner: Remove test folder from __init__
6aad879
@polqubiq
[IMP] mail_activity_partner: pre-commit stuff
57f6d7b
@hugo-cordoba
Copy link

Hello, check the name of the PR. I think this migration corresponds to the module 'mail_activity_partner' not to the module 'product_pricelist_margin' :)

@polqubiq polqubiq changed the title [16.0][MIG] product_pricelist_margin: Migration to version 16.0 [16.0][MIG] mail_activity_partner: Migration to version 16.0 Jun 6, 2023
@polqubiq
Copy link
Contributor Author

polqubiq commented Jun 6, 2023

Hello, check the name of the PR. I think this migration corresponds to the module 'mail_activity_partner' not to the module 'product_pricelist_margin' :)

Whoops, you're absolutely right. Well seen! Thank you.

@simahawk simahawk mentioned this pull request Jul 24, 2023
Closed
dariodelzozzo
dariodelzozzo approved these changes Jul 24, 2023
View reviewed changes
Copy link

@dariodelzozzo dariodelzozzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

@simahawk
Copy link
Contributor

/ocabot migration mail_activity_partner

@simahawk
Copy link
Contributor

@polqubiq looks good, tnx. Just one nitpicking step if is possible for you: could you please amend the last commit to be [16.0][MIG] <module>: Migration to 16.0? You can see a similar commit for 15.0.

See guidelines https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#how-to

@polqubiq polqubiq force-pushed the 16.0-mig-mail_activity_partner branch from 54a5271 to 15490e0 Compare November 17, 2023 08:59
@polqubiq
Copy link
Contributor Author

polqubiq commented Nov 17, 2023 •
edited
Loading

@polqubiq looks good, tnx. Just one nitpicking step if is possible for you: could you please amend the last commit to be [16.0][MIG] <module>: Migration to 16.0? You can see a similar commit for 15.0.

See guidelines https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0#how-to

@simahawk I think it's not [16.0][MIG] <module>: Migration to 16.0. It is [MIG] $module: Migration to 16.0 instead. I've just made the change. Thanks!

@simahawk
Copy link
Contributor

@simahawk I think it's not [16.0][MIG] <module>: Migration to 16.0. It is [MIG] $module: Migration to 16.0 instead. I've just made the change. Thanks!

image

The odoo version can be there when is a migration 😉

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1156-by-simahawk-bump-nobump, awaiting test results.

@simahawk
Copy link
Contributor

FTR tests were red because of our servers issue. Should be fixed now.

@OCA-git-bot OCA-git-bot merged commit 5e967be into OCA:16.0 Nov 17, 2023
2 of 4 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 589b18c. Thanks a lot for contributing to OCA. ❤️

@polqubiq
Copy link
Contributor Author

@simahawk I think it's not [16.0][MIG] <module>: Migration to 16.0. It is [MIG] $module: Migration to 16.0 instead. I've just made the change. Thanks!

image

The odoo version can be there when is a migration 😉

/ocabot merge nobump

I thought that one thing is the name of the pull request and another is the name of the commit 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinagiuliani-rapsodoo valentinagiuliani-rapsodoo valentinagiuliani-rapsodoo approved these changes

@dariodelzozzo dariodelzozzo dariodelzozzo approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.