[ADD] mail_contact_type: #1264
[ADD] mail_contact_type: #1264
Conversation
barkat-matthias
force-pushed
the
14.0-mail-contact-type-04122023
branch
from
a6ea5dd to
876ea51
Compare
barkat-matthias
force-pushed
the
14.0-mail-contact-type-04122023
branch
3 times, most recently
from
e4307f2 to
8379a38
Compare
alexandregaldeano
force-pushed
the
14.0-mail-contact-type-04122023
branch
2 times, most recently
from
1cbd2a5 to
d97aef0
Compare
| name = super()._get_name() | ||
|
|
||
| if ( | ||
| not self._context.get("show_mail_contact_types") |
There was a problem hiding this comment.
@alexandregaldeano, @barkat-matthias I can't see where this context is used in this module ?
I suppose we should add it in the mail composer (not the one from accounting to avoid extra dependency which should be take care by an other module.
barkat-matthias
force-pushed
the
14.0-mail-contact-type-04122023
branch
from
cd9f71c to
a261bc7
Compare
Provides a method to use on mail templates to select contacts by their categories. --------- Co-authored-by: Pierre Verkest <[email protected]> Co-authored-by: Alexandre Galdeano <[email protected]> Co-authored-by: Matthias BARKAT <[email protected]>
barkat-matthias
force-pushed
the
14.0-mail-contact-type-04122023
branch
from
a261bc7 to
0e290a8
Compare
…contact-selection [IMP] - Better contact selection by adding & and or condition
There was a problem hiding this comment.
don't see anything wrong with the code, but if I were to implement such a functionality I'd build on partner_multi_relation, add a code field to relation types and look at that code in contact_by_types/_name_search
| name = super()._get_name() | ||
|
|
||
| if ( | ||
| not self._context.get("show_mail_contact_types") |
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at dd253c8. Thanks a lot for contributing to OCA. ❤️ |
Provides a method to use on mail templates to select contacts by their categories.