Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] fetchmail_thread_default #1329

Merged
merged 23 commits into from
Mar 19, 2024

Conversation

ntsirintanis
Copy link
Contributor

No description provided.

@ntsirintanis ntsirintanis force-pushed the 16.0-mig-fetchmail_thread_default branch from ab8e433 to a346cbd Compare March 8, 2024 10:43
@@ -41,6 +41,7 @@ def test_unbound_incoming_email(self):
).message_process(
self.server.object_id.model,
MAIL_TEMPLATE.format(
return_path="[email protected]",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spombot?

Copy link
Member

@hbrunn hbrunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apart from the typo

@ntsirintanis ntsirintanis force-pushed the 16.0-mig-fetchmail_thread_default branch from a346cbd to 09c6748 Compare March 19, 2024 08:13
@ntsirintanis ntsirintanis force-pushed the 16.0-mig-fetchmail_thread_default branch from 09c6748 to 0570fa6 Compare March 19, 2024 08:20
@ntsirintanis
Copy link
Contributor Author

Red because

2024-03-19 08:22:47,852 369 ERROR odoo odoo.addons.mail_tracking.tests.test_mail_tracking: FAIL: TestMailTracking.test_db_env_no_cr
Traceback (most recent call last):
  File "/__w/social/social/mail_tracking/tests/test_mail_tracking.py", line 451, in test_db_env_no_cr
    response = controller.mail_tracking_open(db, tracking.id, False)
  File "/opt/odoo/odoo/http.py", line 697, in route_wrapper
    result = endpoint(self, *args, **params_ok)
  File "/__w/social/social/mail_tracking/controllers/main.py", line 56, in mail_tracking_open
    with db_env(db) as env:
  File "/usr/lib/python3.10/contextlib.py", line 135, in __enter__
    return next(self.gen)
  File "/__w/social/social/mail_tracking/controllers/main.py", line 29, in db_env
    yield api.Environment(cr, SUPERUSER_ID, {})
  File "/opt/odoo/odoo/api.py", line 527, in __new__
    assert isinstance(cr, BaseCursor)
AssertionError

@hbrunn
Copy link
Member

hbrunn commented Mar 19, 2024

please review/merge #1332, then rebase

yajo and others added 21 commits March 19, 2024 09:43
This addon lets the sysadmin choose a default mail thread sink for incoming mails.

You can use it to forward all unbound incoming emails to a `mail.channel` where only certain users are subscribed and can triage them.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-13.0/social-13.0-fetchmail_thread_default
Translate-URL: https://translation.odoo-community.org/projects/social-13-0/social-13-0-fetchmail_thread_default/
On fetchmail_thread_default when creating a new mail.message it says the context["fetchmail_server_id"] is None, the field value is context["default_fetchmail_server_id"].
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: social-14.0/social-14.0-fetchmail_thread_default
Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-fetchmail_thread_default/
Currently translated at 12.5% (1 of 8 strings)

Translation: social-14.0/social-14.0-fetchmail_thread_default
Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-fetchmail_thread_default/it/
@ntsirintanis ntsirintanis force-pushed the 16.0-mig-fetchmail_thread_default branch from 0570fa6 to ea37a5e Compare March 19, 2024 08:44
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@hbrunn
Copy link
Member

hbrunn commented Mar 19, 2024

/ocabot migrate fetchmail_thread_default (that you can do yourself when you submit a migration)
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hi @hbrunn. Your command failed:

Invalid command: migrate.

Ocabot commands

  • ocabot merge major|minor|patch|nobump
  • ocabot rebase
  • ocabot migration {MODULE_NAME}

More information

@hbrunn
Copy link
Member

hbrunn commented Mar 19, 2024

/ocabot migration fetchmail_thread_default
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 19, 2024
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1329-by-hbrunn-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Mar 19, 2024
39 tasks
@OCA-git-bot OCA-git-bot merged commit 6484362 into OCA:16.0 Mar 19, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

@hbrunn The merge process could not be finalized, because command twine upload --repository-url https://upload.pypi.org/legacy/ -u __token__ odoo_addon_fetchmail_thread_default-16.0.1.0.0.1-py3-none-any.whl failed with output:

Uploading distributions to https://upload.pypi.org/legacy/
Uploading odoo_addon_fetchmail_thread_default-16.0.1.0.0.1-py3-none-any.whl
�[?25l
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/45.9 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/45.9 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m  0%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m0.0/45.9 kB�[0m • �[36m--:--�[0m • �[31m?�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m45.9/45.9 kB�[0m • �[33m00:00�[0m • �[31m39.8 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m45.9/45.9 kB�[0m • �[33m00:00�[0m • �[31m39.8 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m45.9/45.9 kB�[0m • �[33m00:00�[0m • �[31m39.8 MB/s�[0m
�[2K�[35m100%�[0m �[90m━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━�[0m �[32m45.9/45.9 kB�[0m • �[33m00:00�[0m • �[31m39.8 MB/s�[0m
�[?25h�[33mWARNING �[0m Error during upload. Retry with the --verbose option for more details. 
�[31mERROR   �[0m HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         'description-content-type' must be one of ['text/x-rst',               
         'text/markdown', 'text/plain'], not ''. See                            
         https://packaging.python.org/specifications/core-metadata for more     
         information.                                                           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.