Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] mail_activity_validation: Migration to 17.0 #1336

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 80 additions & 0 deletions mail_activity_validation/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@
========================
Mail Activity Validation
========================

..
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! This file is generated by oca-gen-addon-readme !!
!! changes will be overwritten. !!
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
!! source digest: sha256:7e33da1ed5c5cfff367017b42fdea1fcd4c0280a79870df35a91afc0f8ae1177
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

.. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png
:target: https://odoo-community.org/page/development-status
:alt: Beta
.. |badge2| image:: https://img.shields.io/badge/licence-AGPL--3-blue.png
:target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
:alt: License: AGPL-3
.. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fsocial-lightgray.png?logo=github
:target: https://github.com/OCA/social/tree/17.0/mail_activity_validation
:alt: OCA/social
.. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
:target: https://translation.odoo-community.org/projects/social-17-0/social-17-0-mail_activity_validation
:alt: Translate me on Weblate
.. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
:target: https://runboat.odoo-community.org/builds?repo=OCA/social&target_branch=17.0
:alt: Try me on Runboat

|badge1| |badge2| |badge3| |badge4| |badge5|

This module allows to define activities as "validation" ones.

This module do nothing if installed as this. You need another module
that do something with the "validation" activities.

**Table of contents**

.. contents::
:local:

Bug Tracker
===========

Bugs are tracked on `GitHub Issues <https://github.com/OCA/social/issues>`_.
In case of trouble, please check there if your issue has already been reported.
If you spotted it first, help us to smash it by providing a detailed and welcomed
`feedback <https://github.com/OCA/social/issues/new?body=module:%20mail_activity_validation%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.

Do not contact contributors directly about support or help with technical issues.

Credits
=======

Authors
-------

* Camptocamp SA

Contributors
------------

- Damien Crier <[email protected]>
- Maksym Yankin <[email protected]>

Maintainers
-----------

This module is maintained by the OCA.

.. image:: https://odoo-community.org/logo.png
:alt: Odoo Community Association
:target: https://odoo-community.org

OCA, or the Odoo Community Association, is a nonprofit organization whose
mission is to support the collaborative development of Odoo features and
promote its widespread use.

This module is part of the `OCA/social <https://github.com/OCA/social/tree/17.0/mail_activity_validation>`_ project on GitHub.

You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
1 change: 1 addition & 0 deletions mail_activity_validation/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
from . import models
20 changes: 20 additions & 0 deletions mail_activity_validation/__manifest__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl.html).

{
"name": "Mail Activity Validation",
"version": "17.0.1.0.0",
"category": "Discuss",
"website": "https://github.com/OCA/social",
"author": "Camptocamp SA, Odoo Community Association (OCA)",
"license": "AGPL-3",
"installable": True,
"application": False,
"summary": "Allow to define validation activities",
"depends": [
"mail",
],
"data": [
"views/mail_activity_type.xml",
],
}
2 changes: 2 additions & 0 deletions mail_activity_validation/models/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
from . import mail_activity_type
from . import mail_activity
32 changes: 32 additions & 0 deletions mail_activity_validation/models/mail_activity.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

from odoo import _, models
from odoo.exceptions import AccessError


class MailActivity(models.Model):
_inherit = "mail.activity"

def action_done_schedule_next(self):
group_intersect = False

Check warning on line 12 in mail_activity_validation/models/mail_activity.py

View check run for this annotation

Codecov / codecov/patch

mail_activity_validation/models/mail_activity.py#L12

Added line #L12 was not covered by tests
if set(self.env.user.groups_id) | set(
self.activity_type_id.validator_group_ids
):
group_intersect = True

Check warning on line 16 in mail_activity_validation/models/mail_activity.py

View check run for this annotation

Codecov / codecov/patch

mail_activity_validation/models/mail_activity.py#L16

Added line #L16 was not covered by tests
if (
self.activity_type_id.category != "validation"
or not self.activity_type_id.validator_group_ids
or group_intersect
):
Comment on lines +12 to +21

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
group_intersect = False
if set(self.env.user.groups_id) | set(
self.activity_type_id.validator_group_ids
):
group_intersect = True
if (
self.activity_type_id.category != "validation"
or not self.activity_type_id.validator_group_ids
or group_intersect
):
if (
self.activity_type_id.category != "validation"
or not self.activity_type_id.validator_group_ids
or self.env.user.groups_id & self.activity_type_id.validator_group_ids
):

return super().action_done_schedule_next()

Check warning on line 22 in mail_activity_validation/models/mail_activity.py

View check run for this annotation

Codecov / codecov/patch

mail_activity_validation/models/mail_activity.py#L22

Added line #L22 was not covered by tests

raise AccessError(
_(
"Only validators in groups {} are " "allowed to validate this activity."
).format(
"\n".join(
g.display_name for g in self.activity_type_id.validator_group_ids
)
)
Comment on lines +25 to +31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_(
"Only validators in groups {} are " "allowed to validate this activity."
).format(
"\n".join(
g.display_name for g in self.activity_type_id.validator_group_ids
)
)
_(
"Only validators in groups %s are allowed to validate this activity.",
", ".join(self.activity_type_id.validator_group_ids.mapped("display_name")),
)

)
16 changes: 16 additions & 0 deletions mail_activity_validation/models/mail_activity_type.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# Copyright 2022 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)

from odoo import fields, models


class MailActivityType(models.Model):
_inherit = "mail.activity.type"

category = fields.Selection(selection_add=[("validation", "Validation")])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an ondelete property

validator_group_ids = fields.Many2many(
"res.groups",
"mail_activity_groups_rel",
"activity_id",
"group_id",
)
3 changes: 3 additions & 0 deletions mail_activity_validation/pyproject.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build-system]
requires = ["whool"]
build-backend = "whool.buildapi"
2 changes: 2 additions & 0 deletions mail_activity_validation/readme/CONTRIBUTORS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Damien Crier \<<[email protected]>\>
- Maksym Yankin \<<[email protected]>\>
4 changes: 4 additions & 0 deletions mail_activity_validation/readme/DESCRIPTION.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
This module allows to define activities as "validation" ones.

This module do nothing if installed as this. You need another module
that do something with the "validation" activities.
Loading
Loading