[17.0][MIG] mail_show_follower: Migration to 17.0 #1440
Conversation
Display CC according to notification_type
Currently translated at 100.0% (7 of 7 strings) Translation: social-12.0/social-12.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-12-0/social-12-0-mail_show_follower/fr/
As commented in OCA#788 the PR should be merged manually but we should update the version of the module as a minor update cc @ValentinVinagre @eLBati @MiquelRForgeFlow @HaraldPanten
Co-authored-by: Miquel Raïch <[email protected]>
[REF] Compact comment
Added settings to customize notification and translations to important parts of the message. [FIX] Security fixes and simplified customization Field `show_followers_partner_format` formatted with %(param)s Removed CSS customizations [FIX] README options [FIX] Index.html configure [FIX] Several changes - Removed unnecesary properties on res_config_settings - Markup safe on partner_format - Use email_domain_extract instead own one
When using composer, doesn't include all recipients of the message on the notification.
In the highly improbable but actually possible and real world case that a partner has more than one user associated, this change makes the emails able to send. @moduon MT-1634
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/
Currently translated at 62.5% (10 of 16 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/es/
Currently translated at 100.0% (16 of 16 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/es/
Currently translated at 25.0% (4 of 16 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
Currently translated at 37.5% (6 of 16 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
Currently translated at 100.0% (16 of 16 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/
Currently translated at 100.0% (17 of 17 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/pt_BR/
Currently translated at 100.0% (17 of 17 strings) Translation: social-16.0/social-16.0-mail_show_follower Translate-URL: https://translation.odoo-community.org/projects/social-16-0/social-16-0-mail_show_follower/it/
|
Files impacting translations have been reverted, this is ready for review. |
|
Any updates on this? |
|
I have been using this on my Odoo site in production without issues. If anything else is required on my end to get it approved, please let me know. |
|
@chusamo ? |
|
This PR has the |
|
Can you squash your migration commits in a single one? |
|
@etobella Maybe I should make a supersede? Since the user isn't responding and doesn't seem very active |
|
Sure! |
|
Apologies...I'm here. I've been caught up with year-end tasks at my company. I can try to knock this out if it isn't too late. |
|
@ericchew87 Sure! I hadn’t started working on the supersede, so feel free to complete it yourself. |
ericchew87
force-pushed
the
17.0-mig-mail_show_follower
branch
from
49fa582 to
afce67d
Compare
|
Were those the ones you needed squashed? Please let me know if you need me to do anything else. Thank you. |
|
Hey @ericchew87 , I think you should have kept the pre-commit auto fixes commit, also in the migration commit is missing the module name. In the following link you can find more information if you search in the 'how-to' section. https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0 |
There was a problem hiding this comment.
Tested and working fine. Just a minor change in the function when calling super(). Additionally, please squash administrative commits according to this guide:
https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests
I also think you should split the commits into two:
- The first for pre-commit auto fixes.
- The second for migration, as explained in this guide:
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0
If you have any questions, please let me know. Thanks!
TT51935
| return super()._send( | ||
| auto_commit=auto_commit, | ||
| raise_exception=raise_exception, | ||
| smtp_session=smtp_session, |
There was a problem hiding this comment.
Please add the new parameter to the super() call.
| smtp_session=smtp_session, | |
| smtp_session=smtp_session, | |
| alias_domain_id=alias_domain_id |
|
Thank you both for your input. I'm not sure how quickly I will be able to get to this, but will try to make some time. If you prefer to get it done on your end to push it along, that works for me as well. |
My company just started using Odoo in July of 2024. This is my attempt to port this OCA module which we want to utilize in version 17.0. One place I think needs work is the translations. I changed some text to be more concise but then realized afterwards it would mess up the translations doing this. I appreciate any tips on whether its worth making this change, or if I should revert the text to what was in 16.0.
Thank you!
Eric