-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] mail_activity_board: add no_open to avoid accessing the record and using the open_origin function instead. #1522
[16.0][FIX] mail_activity_board: add no_open to avoid accessing the record and using the open_origin function instead. #1522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase to try and fix runboat?
…and using the open_origin function instead.
ff63920
to
5abb13b
Compare
@StefanRijnhart Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I'm missing something, but when I check on runboat, the difference that I see is that the header that carries the title of the related record is no longer clickable. I can still navigate to the record clicking the link 'Partner' below it, but I am not sure how this is an improvement. Can you help me understand?
The issue is that the tittle is a button calling the "open_origin" function, but having a m2o field inside makes clicking on the title access the record the activity is assigned to instead of calling the function. With the changes i propose you cannot access the record so the function is called allowing for custom modules to inherit the function a change the behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying! Indeed, the link is still clickable. It's just no longer in a blue font.
/ocabot merge minor |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 0b54346. Thanks a lot for contributing to OCA. ❤️ |
No description provided.