Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] mail_activity_board: add no_open to avoid accessing the record and using the open_origin function instead. #1522

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

TelmoSuarez
Copy link
Contributor

No description provided.

@TelmoSuarez TelmoSuarez changed the title [FIX] mail_activity_board: add no_open to avoid accessing the record and using the open_origin function instead. [16.0][FIX] mail_activity_board: add no_open to avoid accessing the record and using the open_origin function instead. Dec 19, 2024
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase to try and fix runboat?

@TelmoSuarez TelmoSuarez force-pushed the 16.0-fix-mail_activity_board branch from ff63920 to 5abb13b Compare February 25, 2025 10:35
@TelmoSuarez
Copy link
Contributor Author

@StefanRijnhart Done!

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm missing something, but when I check on runboat, the difference that I see is that the header that carries the title of the related record is no longer clickable. I can still navigate to the record clicking the link 'Partner' below it, but I am not sure how this is an improvement. Can you help me understand?
image

@TelmoSuarez
Copy link
Contributor Author

The issue is that the tittle is a button calling the "open_origin" function, but having a m2o field inside makes clicking on the title access the record the activity is assigned to instead of calling the function. With the changes i propose you cannot access the record so the function is called allowing for custom modules to inherit the function a change the behavior.
This means the title should be still clickable, at least i can in runboat testing.

Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying! Indeed, the link is still clickable. It's just no longer in a blue font.

@StefanRijnhart
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1522-by-StefanRijnhart-bump-minor, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 0b54346. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 197d76c into OCA:16.0 Feb 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants