Skip to content

[ADD] mail_autosubscribe_partner_parent: New module mail_autosubscribe_partner_parent#1525

Closed
mpascuall wants to merge 1 commit intoOCA:16.0from
APSL:16.0-add-mail_autosubscribe_partner_parent
Closed

[ADD] mail_autosubscribe_partner_parent: New module mail_autosubscribe_partner_parent#1525
mpascuall wants to merge 1 commit intoOCA:16.0from
APSL:16.0-add-mail_autosubscribe_partner_parent

Conversation

@mpascuall
Copy link
Copy Markdown

This module extends mail_autosubscribe functionality to add the partner parent in copy of their child partner documents.

cc https://github.com/APSL 165068
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @BernatObrador @ppyczko please review

@mpascuall mpascuall force-pushed the 16.0-add-mail_autosubscribe_partner_parent branch 2 times, most recently from 6c231de to 6fa4e5c Compare December 20, 2024 12:23
@mpascuall mpascuall force-pushed the 16.0-add-mail_autosubscribe_partner_parent branch 4 times, most recently from 1f08c05 to 7771738 Compare January 8, 2025 12:23
@mpascuall
Copy link
Copy Markdown
Author

Hi @pedrobaeza, sorry for pinging you out directly. The tests for the mail_autosubscribe module are failing because in this module we add the parent partner, and the tests do not take this into account. What would be the best way to solve this? Could we create an IMP in mail_autosubscribe with a boolean to mark whether to also add the parent partner in CC? Looking forward to your response, thank you very much!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 16, 2025
@pedrobaeza
Copy link
Copy Markdown
Member

What I'm seeing is that mail_composer_cc_bcc has a signature change upstream and there's a mechanism for failing if that happens. Can you rebase to see if this has changed meanwhile?

@mpascuall mpascuall force-pushed the 16.0-add-mail_autosubscribe_partner_parent branch from 7771738 to a62d565 Compare January 22, 2025 06:23
@mpascuall
Copy link
Copy Markdown
Author

What I'm seeing is that mail_composer_cc_bcc has a signature change upstream and there's a mechanism for failing if that happens. Can you rebase to see if this has changed meanwhile?

Done! But it still fails, what should i do?

@pedrobaeza
Copy link
Copy Markdown
Member

The signature CRC should be changed in the test, and check that the new code is working the same with the module. You can ping the author of that code to see if they can perform the change.

@github-actions
Copy link
Copy Markdown

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 25, 2025
@github-actions github-actions Bot closed this Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants