Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] mail_print: Migration to version 17.0 #1532

Merged
merged 5 commits into from
Jan 18, 2025
Merged

[17.0][MIG] mail_print: Migration to version 17.0 #1532

merged 5 commits into from
Jan 18, 2025

Conversation

carlos-lopez-tecnativa
Copy link
Contributor

TT51934

@Tecnativa @pedrobaeza @chienandalu could you please review this

@carlos-lopez-tecnativa
[ADD] mail_print: new module to print messages from chatter
6f276d7
@carlos-lopez-tecnativa
[FIX] mail_print: prevent errors during the test tour when web_respon…
40749ba 
…sive is installed.
@carlos-lopez-tecnativa
[IMP] mail_print: Allow printing messages from incoming mail
bfac37d 
Before this commit, the option to print messages was only available for messages sent from Odoo. After this commit, it is now possible to print incoming messages as well.
@carlos-lopez-tecnativa
[IMP] mail_print: pre-commit auto fixes
609747f
chienandalu
chienandalu reviewed Dec 31, 2024
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok. Tours are failing though

@pedrobaeza
Copy link
Member

/ocabot migration mail_print

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Dec 31, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 31, 2024
Open
32 tasks
@carlos-lopez-tecnativa
Copy link
Contributor Author

Tested ok. Tours are failing though

The test fails because the module mail_send_confirmation displays a dialog before sending the message. What is the best way to fix this?
image

@chienandalu
Copy link
Member

Maybe you can pre-create it to avoid sending it as you just need to click on the print button

@carlos-lopez-tecnativa
Copy link
Contributor Author

Maybe you can pre-create it to avoid sending it as you just need to click on the print button

Thanks for your suggestion. The CI is now green, and the test has passed successfully. Could you please update your review?

chienandalu
chienandalu approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

pedrobaeza
pedrobaeza approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1532-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 939bc77 into OCA:17.0 Jan 18, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 61e573e. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-mail_print branch January 18, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@chienandalu chienandalu chienandalu approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
4 participants
@carlos-lopez-tecnativa @pedrobaeza @chienandalu @OCA-git-bot