[17.0][IMP] mail_notification_custom_subject: Do not replace the subject if it is already defined + add inside replace option #1548
Conversation
|
Hi @yajo, |
There was a problem hiding this comment.
I see the subject_to_replace feature very limited, as you can only do one replacement. But I think it's not needed as well, as you can do a whole replacement and use expressions to paint that. And anyway, for the particular case we need it, we should use a stored value in the mail template (object.partner_id.comercial or object.name if I'm not wrong).
|
It is important to clarify that you can set several inside template records to make several replacements if necessary. I will change the behavior of the |
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
809d101 to
9469da8
Compare
mail_notification_custom_subject/models/mail_message_custom_subject.py
Outdated
Show resolved
Hide resolved
mail_notification_custom_subject/models/mail_message_custom_subject.py
Outdated
Show resolved
Hide resolved
mail_notification_custom_subject/models/mail_message_custom_subject.py
Outdated
Show resolved
Hide resolved
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
9469da8 to
7594aa1
Compare
… it is already set If we write something from the mail thread (without subject) it is only when it should replace the subject. TT52259
…ing the subject If there is an error in the template we want to render the subject to be shown and acted upon. Related to OCA#1548 (comment) TT52259
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
7594aa1 to
eb7d3ac
Compare
…ception to know what has happened TT52259
Example use Case: Our company is called: MY_COMPANY_NAME but is known as MCN, we want to replace in some places the subject line so that it is sent with MCN TT52259
victoralmau
force-pushed
the
17.0-imp-mail_notification_custom_subject-TT52259-v2
branch
from
eb7d3ac to
adb7204
Compare
| rendered_subject_to_replace, | ||
| rendered_subject_template, | ||
| ) | ||
| except Exception: |
There was a problem hiding this comment.
Do we need a double except catch? I think the general one serves enough.
Changes done:
Please @pedrobaeza and @sergio-teruel can you review it?
@Tecnativa TT52259