[17.0][IMP] mail_forward: Add option to forward a message to another thread #1557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
reviewed
Jan 24, 2025
There was a problem hiding this comment.
In a functional test, I found the word "Recipients" a bit confusing due to 2 things:
- I think it should be "Followers", as it's the usual nomenclature.
- "Followers" / "Recipient" of what? When forwarding to other thread, that's the doubt. Put "of the target document" when redirecting to other thread.
carlos-lopez-tecnativa
force-pushed
the
17.0-mail_forward-to-thread
branch
2 times, most recently
from
7d1381a to
b5de746
Compare
pedrobaeza
reviewed
Jan 27, 2025
carlos-lopez-tecnativa
force-pushed
the
17.0-mail_forward-to-thread
branch
from
b5de746 to
6a3d5f6
Compare
pedrobaeza
reviewed
Jan 27, 2025
carlos-lopez-tecnativa
force-pushed
the
17.0-mail_forward-to-thread
branch
2 times, most recently
from
093b444 to
1296524
Compare
This option posts a new message in the other thread, including the attachments, but does not add them as followers—only notifying the current followers of the other thread.
carlos-lopez-tecnativa
force-pushed
the
17.0-mail_forward-to-thread
branch
from
1296524 to
300ef2d
Compare
pedrobaeza
approved these changes
Jan 27, 2025
|
/ocabot merge major |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 27a05df. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option posts a new message in the other thread, including the attachments, but does not add them as followers—only notifying the current followers of the other thread.
TT54602
@Tecnativa @pedrobaeza @chienandalu