[15.0][ADD] mail_hide_footer #1600
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
reviewed
Feb 19, 2025
Comment on lines
16
to
17
| r'<p\s*style\s*=\s*["\']color:\s*#555555;\s*margin-top:\s*32px;["\']>' | ||
| r"\s*Sent.*?</p>", |
There was a problem hiding this comment.
This looks a bit too specific and fragile. I think it may be safer to go with template inheritance.
AungKoKoLin1997
force-pushed
the
15.0-add-email_hide_footer
branch
from
bb77b55 to
38de628
Compare
yostashiro
reviewed
Feb 19, 2025
| inherit_id="mail.message_notification_email" | ||
| > | ||
| <xpath | ||
| expr="//div[@t-out='signature']/following-sibling::p[1]" |
There was a problem hiding this comment.
Can we try this, so that we don't depend on the position of the signature <div>?
Suggested change
| expr="//div[@t-out='signature']/following-sibling::p[1]" | |
| expr="//span[@t-if='company.name']/parent::p" |
|
@AungKoKoLin1997 Can you please add tests. |
AungKoKoLin1997
force-pushed
the
15.0-add-email_hide_footer
branch
from
38de628 to
3642a5b
Compare
AungKoKoLin1997
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module allows hiding the email footer for a specific model by enabling the
hide_email_footeroption.@qrtl QT4979