Repository navigation
[19.0][MIG] stock_available_location_get_domain: Migration to 19.0 - #94
Open
ivantodorovich wants to merge 5 commits into
Open
ivantodorovich wants to merge 5 commits into
ivantodorovich wants to merge 5 commits into
Conversation
OCA-git-bot
added
series:19.0
mod:stock_available_location_get_domain
ivantodorovich
force-pushed
the
19.0-mig-stock_available_location_get_domain
branch
3 times, most recently
from
October 27, 2026 19:20
4e59d87 to
e73db33
Compare
ivantodorovich
marked this pull request as ready for review
October 27, 2026 19:34
Contributor
Author
|
ping @rousseldenis @lmignon @bizzappdev , as you worked on this module :) |
lmignon
reviewed
Nov 2, 2026
lmignon
suggested changes
Nov 2, 2026
lmignon
left a comment
lmignon
left a comment
Contributor
There was a problem hiding this comment.
Can you keep the original signature extract_subdomains(domain, submodel_field). I use-it with others params...
ivantodorovich
force-pushed
the
19.0-mig-stock_available_location_get_domain
branch
from
November 2, 2026 12:06
e73db33 to
96fdf26
Compare
Contributor
Author
|
Thanks for the review, @lmignon ! I restored the |
lmignon
approved these changes
Nov 2, 2026
Contributor
There was a problem hiding this comment.
Thank you for all this hard work, @ivantodorovich, and for taking my comments into account 😏 LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to 19.0.
DomainAPI: theodoo.osv.expressioninternals it used are removed in 19.0. The behaviour is unchanged: the conditions on other fields of the quant are removed, along with the operators left without operands._get_domain_location_for_locationsnow returns aDomain.anyandnot anyoperators onlocation_id.