Repository navigation
[19.0] [FIX] sale_stock_available_info_popup: write the unit like the other rows - #96
Merged
OCA-git-bot merged 1 commit intoOct 29, 2026
Conversation
OCA-git-bot
added
mod:sale_stock_available_info_popup
ivantodorovich
marked this pull request as ready for review
October 28, 2026 15:16
ivantodorovich
force-pushed
the
19.0-fix-sale_stock_available_info_popup-row
branch
from
October 28, 2026 15:18
5edddf7 to
6bfb267
Compare
ivantodorovich
changed the title
Ricardoalso
approved these changes
Oct 29, 2026
Contributor
Author
Member
|
Isn't this data interesting to be the first one? |
Contributor
Author
|
The "Available to Promise" is a subset of the "Fresh Available" so it seems more natural to have it below. |
Member
|
Yeah, I think we can still keep it the first, while fixing the UoM thing. |
…rows The Available to promise row showed the unit with display_name, unlike the other rows of the popover.
ivantodorovich
force-pushed
the
19.0-fix-sale_stock_available_info_popup-row
branch
from
October 29, 2026 14:43
6bfb267 to
a765ec1
Compare
ivantodorovich
changed the title
Contributor
Author
|
It's done! |
Contributor
|
On my way to merge this fine PR! |
Contributor
|
It looks like something changed on |
Contributor
|
Congratulations, your PR was merged at f6f0272. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Available to promise row wrote its unit with
display_name, unlike the other rows of the popover. It now writes it the same way as they do.Before:
