Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] product_packaging_multi_barcode: remove packaging_id of product.barcode on product form view #590

Merged

Conversation

QuocDuong1306
Copy link

Depend on:

Now users can not create a new barcode including packaging on General Information tab because it will raise this error (in PR above). So I remove the view to avoid confusion.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cyrilmanuel
Copy link
Contributor

hii @pedrobaeza , can you merge this PR please ?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Mar 27, 2024
@pedrobaeza
Copy link
Member

It says it depends on #563

@cyrilmanuel
Copy link
Contributor

Hi @pedrobaeza the pr #563 is merged, can you merge this one ?

thanks a lot

@pedrobaeza
Copy link
Member

There are conflicts right now.

@QuocDuong1306 QuocDuong1306 force-pushed the 16.0-imp-product_packaging_multi_barcode branch from 35c9a6e to 6aeac9d Compare July 10, 2024 07:12
@QuocDuong1306
Copy link
Author

Hello @pedrobaeza , the PR is updated, could you have a look?

@pedrobaeza
Copy link
Member

Well, I don't know the module, but I merge based on the reviews:

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-590-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0c5c30b into OCA:16.0 Jul 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3034d92. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants