[14.0][ADD] stock_picking_purchase_order_alert by antoniodavid · Pull Request #1913 · OCA/stock-logistics-workflow

antoniodavid · 2025-04-11T04:59:18Z

This module adds alert notifications when the quantity being received in purchase receipts
exceeds the ordered quantity by more than a configurable threshold percentage (default 30%).

Often warehouse staff receive products in different units of measure than ordered,
which can lead to input errors. For example, if 6,000 units were ordered but the
staff tries to receive 60,000 units, this module will display a warning.

The module provides:

A warning banner in the receipt form when quantities exceed the threshold
A configurable feature that can be enabled/disabled via settings
A configurable percentage threshold for when alerts should appear
Proper handling of different units of measure between order and receipt
Prevents validation of receipts when quantities exceed the threshold percentage
Forces users to review and correct quantities before validating the receipt

rousseldenis · 2025-04-11T07:13:29Z

@antoniodavid Thanks for this. Seems promising.

christian-ramos-tecnativa

It looks pretty good, can you check my comments? Thanks

AlvaroRM11 · 2025-04-11T12:06:01Z

Looks good, also, don't forget to run the pre-commit stuff

christian-ramos-tecnativa · 2025-04-11T16:50:06Z

@antoniodavid Now the code LGTM just some last changes:
The PR name should be: [14.0][ADD] stock_picking_order_alert
There should be just 1 commit called: [ADD] stock_picking_order_alert
Thanks!

antoniodavid · 2025-04-11T17:31:24Z

@antoniodavid Now the code LGTM just some last changes: The PR name should be: [14.0][ADD] stock_picking_order_alert There should be just 1 commit called: [ADD] stock_picking_order_alert Thanks!

Ready!!!

rrebollo

Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.

sheragar

LGTM. Funtional Review 👍

rrebollo

Code Review. LGTM!

antoniodavid · 2025-04-15T15:14:34Z

ping @rousseldenis

OCA-git-bot · 2025-04-16T05:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

rousseldenis · 2025-04-15T15:18:05Z

+class ResConfigSettings(models.TransientModel):
+    _inherit = "res.config.settings"
+
+    display_quantity_alert_percentage = fields.Boolean(


Maybe something on picking type level is more flexible.

rousseldenis · 2025-04-15T15:18:17Z

+        default=False,
+        config_parameter="stock_picking_order_alert.display_quantity_alert_percentage",
+    )
+    quantity_alert_percentage = fields.Float(


Same as above

rousseldenis · 2025-04-15T15:20:23Z

+            # Only apply quantity check if feature is enabled
+            if is_enabled:
+                # Force compute has_quantity_alert before validation
+                picking._compute_has_quantity_alert()


rousseldenis · 2025-04-15T15:21:01Z

+        """Override button_validate to prevent validation
+        when quantity alerts exist"""
+        for picking in self:
+            is_enabled, alert_percentage = picking._is_quantity_alert_enabled()


This should be done in compute instead

@rousseldenis thanks, for all advice. Could you review again?

christian-ramos-tecnativa

Also check pre-commit and tests. Thanks

antoniodavid · 2025-05-27T09:35:57Z

Also check pre-commit and tests. Thanks

Ready @Christian-RB

christian-ramos-tecnativa

After some time working with this module I have the feeling that
we don't really need to compare de done value with the purchase. IMO using the demand field product_uom_qty should be good enough and also way more generic as that field is updated directly from the purchase/sale. WDYT @antoniodavid

Co-authored-by: ChristianRB <69461150+Christian-RB@users.noreply.github.com>

edescalona

LGTM.
Hi @antoniodavid just a question: is the warning message displayed on the receipt fixed forever, even if the user had already validated the receipt with that difference in quantities?

antoniodavid · 2025-06-06T14:05:56Z

After some time working with this module I have the feeling that we don't really need to compare de done value with the purchase. IMO using the demand field product_uom_qty should be good enough and also way more generic as that field is updated directly from the purchase/sale. WDYT @antoniodavid

Hi @Christian-RB, all changes have been made; please confirm.

antoniodavid · 2025-08-11T16:34:09Z

@Christian-RB, please check & approve this PR.

antoniodavid · 2025-08-11T21:05:39Z

ping @rousseldenis.

github-actions · 2025-12-14T12:51:58Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

christian-ramos-tecnativa suggested changes Apr 11, 2025

View reviewed changes

Comment thread stock_picking_order_alert/README.rst

Comment thread stock_picking_order_alert/models/res_config_settings.py Outdated

Comment thread stock_picking_order_alert/models/stock_picking.py Outdated

Comment thread stock_picking_order_alert/models/stock_picking.py Outdated

antoniodavid changed the title ~~[ADD] [14.0] add stock picking order alert~~ [WIP][ADD] [14.0] add stock picking order alert Apr 11, 2025

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from 6aa2e96 to a176084 Compare April 11, 2025 14:43

antoniodavid changed the title ~~[WIP][ADD] [14.0] add stock picking order alert~~ [ADD] [14.0] add stock picking order alert Apr 11, 2025

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from a176084 to e2a45a7 Compare April 11, 2025 16:11

antoniodavid requested a review from christian-ramos-tecnativa April 11, 2025 16:25

antoniodavid changed the title ~~[ADD] [14.0] add stock picking order alert~~ [14.0][ADD] stock_picking_order_alert Apr 11, 2025

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from e2a45a7 to d8f2b45 Compare April 11, 2025 17:18

rrebollo approved these changes Apr 11, 2025

View reviewed changes

Comment thread stock_picking_order_alert/models/res_config_settings.py

Comment thread stock_picking_order_alert/models/stock_picking.py Outdated

Comment thread stock_picking_order_alert/models/stock_picking.py Outdated

Comment thread stock_picking_order_alert/models/stock_picking.py Outdated

sheragar approved these changes Apr 14, 2025

View reviewed changes

AlvaroRM11 approved these changes Apr 14, 2025

View reviewed changes

rrebollo approved these changes Apr 14, 2025

View reviewed changes

Comment thread stock_picking_order_alert/models/res_config_settings.py

christian-ramos-tecnativa approved these changes Apr 14, 2025

View reviewed changes

OCA-git-bot added the approved label Apr 14, 2025

OCA-git-bot added the ready to merge label Apr 16, 2025

rousseldenis reviewed Apr 23, 2025

View reviewed changes

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch 2 times, most recently from 229935b to c3395ba Compare May 9, 2025 22:11

antoniodavid changed the title ~~[14.0][ADD] stock_picking_order_alert~~ [14.0][ADD] stock_picking_purchase_order_alert May 9, 2025

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from c3395ba to f850afc Compare May 23, 2025 00:46

christian-ramos-tecnativa suggested changes May 23, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels May 23, 2025

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from 6b2ac2c to 5b22144 Compare May 23, 2025 13:56

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch 3 times, most recently from 40cb259 to 113cb70 Compare May 26, 2025 23:39

christian-ramos-tecnativa suggested changes May 27, 2025

View reviewed changes

Comment thread stock_picking_purchase_order_alert/migrations/14.0.1.0.1/pre-migration.py Outdated

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from 113cb70 to bcb7324 Compare May 27, 2025 13:19

antoniodavid added 2 commits May 27, 2025 09:22

[ADD] stock_picking_order_alert

bf9975f

[FIX] stock_picking_purchase_order_alert: Enable the use custom groups

2659bd8

antoniodavid force-pushed the 14.0-add-stock-picking-order-alert branch from bcb7324 to 2659bd8 Compare May 27, 2025 13:22

christian-ramos-tecnativa suggested changes May 29, 2025

View reviewed changes

Comment thread stock_picking_purchase_order_alert/models/stock_picking.py

[IMP] stock_picking_purchase_order_alert: Depends field product_uom_qty

835c89d

Co-authored-by: ChristianRB <69461150+Christian-RB@users.noreply.github.com>

edescalona approved these changes Jun 5, 2025

View reviewed changes

christian-ramos-tecnativa approved these changes Aug 11, 2025

View reviewed changes

OCA-git-bot added the approved label Aug 11, 2025

github-actions Bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 14, 2025

github-actions Bot closed this Jan 18, 2026

syci mentioned this pull request Feb 12, 2026

[14.0][ADD] stock_picking_purchase_order_alert #2252

Open

Uh oh!

Conversation

antoniodavid commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rousseldenis commented Apr 11, 2025

Uh oh!

christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlvaroRM11 commented Apr 11, 2025

Uh oh!

christian-ramos-tecnativa commented Apr 11, 2025

Uh oh!

antoniodavid commented Apr 11, 2025

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sheragar left a comment

Choose a reason for hiding this comment

Uh oh!

rrebollo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

antoniodavid commented Apr 15, 2025

Uh oh!

OCA-git-bot commented Apr 16, 2025

Uh oh!

rousseldenis Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

rousseldenis Apr 15, 2025

Choose a reason for hiding this comment

Uh oh!

antoniodavid May 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antoniodavid commented May 27, 2025

Uh oh!

Uh oh!

christian-ramos-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edescalona left a comment

Choose a reason for hiding this comment

Uh oh!

antoniodavid commented Jun 6, 2025

Uh oh!

antoniodavid commented Aug 11, 2025

Uh oh!

antoniodavid commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antoniodavid commented Apr 11, 2025 •

edited

Loading

antoniodavid May 27, 2025 •

edited

Loading

antoniodavid commented Aug 11, 2025 •

edited

Loading