Skip to content

Conversation

@sabrinaRMartin
Copy link
Contributor

@sabrinaRMartin sabrinaRMartin commented Jan 8, 2026

@sabrinaRMartin sabrinaRMartin force-pushed the 18.0-mig-stock_warn_option branch from 11f7c47 to 6261817 Compare January 8, 2026 16:34
Copy link
Contributor

@Shide Shide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuctional review.

Great work @sabrinaRMartin on this contribution and thank you for the effort put into migrating and adapting the module to Odoo 18.
The following functional tests have been performed to validate the behavior of the module:

Test 1: Activation of stock warnings in Inventory settings – OK
Test 2: Configuration of a picking warning option on a partner – OK
Test 3: Creation of a stock picking for a partner with a warning option configured and verification of the warning behavior – OK
Test 4: Validation that warning options in other modules (sales and accounting) continue to work without regression – OK

image image

@jbaudoux
Copy link
Contributor

/ocabot migration stock_warn_option

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 13, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 13, 2026
88 tasks
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-2218-by-rafaelbn-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 21, 2026
Signed-off-by rafaelbn
@OCA-git-bot
Copy link
Contributor

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-2218-by-rafaelbn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@Shide Shide force-pushed the 18.0-mig-stock_warn_option branch from 7cb3337 to c13f71c Compare January 22, 2026 12:09
@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-2218-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 47f951d into OCA:18.0 Jan 22, 2026
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7b6dde4. Thanks a lot for contributing to OCA. ❤️

@Shide Shide deleted the 18.0-mig-stock_warn_option branch January 22, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants