-
-
Notifications
You must be signed in to change notification settings - Fork 737
[18.0][MIG] stock_warn_option: Migration to 18.0 #2218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
11f7c47 to
6261817
Compare
8a5779a to
7cb3337
Compare
Shide
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
fcvalgar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fuctional review.
Great work @sabrinaRMartin on this contribution and thank you for the effort put into migrating and adapting the module to Odoo 18.
The following functional tests have been performed to validate the behavior of the module:
Test 1: Activation of stock warnings in Inventory settings – OK
Test 2: Configuration of a picking warning option on a partner – OK
Test 3: Creation of a stock picking for a partner with a warning option configured and verification of the warning behavior – OK
Test 4: Validation that warning options in other modules (sales and accounting) continue to work without regression – OK
|
/ocabot migration stock_warn_option |
rafaelbn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
/ocabot merge patch
|
On my way to merge this fine PR! |
|
@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-2218-by-rafaelbn-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
…ck and warning message
7cb3337 to
c13f71c
Compare
|
/ocabot merge patch |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 7b6dde4. Thanks a lot for contributing to OCA. ❤️ |
Migration from 15.0 to 18.0
This module depends on PR:
@moduon @Shide MT-13269
https://www.loom.com/share/5ab05c37d263414f8618fd7b663ec433